2014-07-08 22:20:31

by Himangi Saraogi

Subject: [PATCH] iaf_packet: use BUG_ON

Use BUG_ON(x) rather than if(x) BUG();

The semantic patch that fixes this problem is as follows:

// <smpl>
@@ identifier x; @@
-if (x) BUG();
+BUG_ON(x);
// </smpl>

Signed-off-by: Himangi Saraogi <[email protected]>
Acked-by: Julia Lawall <[email protected]>
---
To send to: "David S. Miller" <[email protected]>,[email protected],[email protected]
net/packet/af_packet.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
index b85c67c..cda8552 100644
--- a/net/packet/af_packet.c
+++ b/net/packet/af_packet.c
@@ -551,8 +551,7 @@ static void prb_setup_retire_blk_timer(struct packet_sock *po, int tx_ring)
{
struct tpacket_kbdq_core *pkc;

- if (tx_ring)
- BUG();
+ BUG_ON(tx_ring);

pkc = tx_ring ? GET_PBDQC_FROM_RB(&po->tx_ring) :
GET_PBDQC_FROM_RB(&po->rx_ring);
--
1.9.1

2014-07-08 23:22:07

by David Miller

Subject: Re: [PATCH] iaf_packet: use BUG_ON

From: Himangi Saraogi <[email protected]>
Date: Wed, 9 Jul 2014 03:50:23 +0530

> Use BUG_ON(x) rather than if(x) BUG();
>
> The semantic patch that fixes this problem is as follows:
>
> // <smpl>
> @@ identifier x; @@
> -if (x) BUG();
> +BUG_ON(x);
> // </smpl>
>
> Signed-off-by: Himangi Saraogi <[email protected]>
> Acked-by: Julia Lawall <[email protected]>

Please repost this with a proper subject line, correcting "iaf_packet".