2014-07-11 20:27:28

by Himangi Saraogi

Subject: [PATCH] ipv6: Use BUG_ON

The semantic patch that makes this transformation is as follows:

// <smpl>
@@ expression e; @@
-if (e) BUG();
+BUG_ON(e);
// </smpl>

Signed-off-by: Himangi Saraogi <[email protected]>
Acked-by: Julia Lawall <[email protected]>
---
To send to: "David S. Miller" <[email protected]>,Alexey Kuznetsov <[email protected]>,James Morris <[email protected]>,Hideaki YOSHIFUJI <[email protected]>,Patrick McHardy <[email protected]>,[email protected],[email protected]
net/ipv6/ip6_output.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c
index fa83bdd..9b395c6 100644
--- a/net/ipv6/ip6_output.c
+++ b/net/ipv6/ip6_output.c
@@ -801,8 +801,8 @@ slow_path:
/*
* Copy a block of the IP datagram.
*/
- if (skb_copy_bits(skb, ptr, skb_transport_header(frag), len))
- BUG();
+ BUG_ON(skb_copy_bits(skb, ptr, skb_transport_header(frag),
+ len));
left -= len;

fh->frag_off = htons(offset);
--
1.9.1

2014-07-11 22:07:10

by David Miller

Subject: Re: [PATCH] ipv6: Use BUG_ON

From: Himangi Saraogi <[email protected]>
Date: Sat, 12 Jul 2014 01:57:17 +0530

> The semantic patch that makes this transformation is as follows:
>
> // <smpl>
> @@ expression e; @@
> -if (e) BUG();
> +BUG_ON(e);
> // </smpl>
>
> Signed-off-by: Himangi Saraogi <[email protected]>
> Acked-by: Julia Lawall <[email protected]>

Applied.