2002-11-27 23:27:26

by Frank Davis

Subject: 2.5.50 : arch/i386/mm/hugetblpage.c error

Hello all,
While 'make bzImage', I received the following error.

Regards,
Frank

arch/i386/mm/hugetlbpage.c:610: parse error before `*'
arch/i386/mm/hugetlbpage.c: In function `hugetlb_sysctl_handler':
arch/i386/mm/hugetlbpage.c:611: number of arguments doesn't match prototype
include/linux/hugetlb.h:14: prototype declaration
arch/i386/mm/hugetlbpage.c:612: warning: implicit declaration of function `proc_dointvec'
arch/i386/mm/hugetlbpage.c:612: `table' undeclared (first use in this function)
arch/i386/mm/hugetlbpage.c:612: (Each undeclared identifier is reported only once
arch/i386/mm/hugetlbpage.c:612: for each function it appears in.)
arch/i386/mm/hugetlbpage.c:612: `write' undeclared (first use in this function)
arch/i386/mm/hugetlbpage.c:612: `file' undeclared (first use in this function)
arch/i386/mm/hugetlbpage.c:612: `buffer' undeclared (first use in this function)
arch/i386/mm/hugetlbpage.c:612: `length' undeclared (first use in this function)
make[1]: *** [arch/i386/mm/hugetlbpage.o] Error 1
make: *** [arch/i386/mm] Error 2

2002-11-27 23:37:14

by Martin Dahl

Subject: [PATCH] Re: 2.5.50 : arch/i386/mm/hugetblpage.c error

> Hello all,
> While 'make bzImage', I received the following error.
>
> Regards,
> Frank
>
> arch/i386/mm/hugetlbpage.c:610: parse error before `*'
> arch/i386/mm/hugetlbpage.c: In function `hugetlb_sysctl_handler':
> arch/i386/mm/hugetlbpage.c:611: number of arguments doesn't match prototype
> include/linux/hugetlb.h:14: prototype declaration
> arch/i386/mm/hugetlbpage.c:612: warning: implicit declaration of function `proc_dointvec'
> arch/i386/mm/hugetlbpage.c:612: `table' undeclared (first use in this function)
> arch/i386/mm/hugetlbpage.c:612: (Each undeclared identifier is reported only once
> arch/i386/mm/hugetlbpage.c:612: for each function it appears in.)
> arch/i386/mm/hugetlbpage.c:612: `write' undeclared (first use in this function)
> arch/i386/mm/hugetlbpage.c:612: `file' undeclared (first use in this function)
> arch/i386/mm/hugetlbpage.c:612: `buffer' undeclared (first use in this function)
> arch/i386/mm/hugetlbpage.c:612: `length' undeclared (first use in this function)
> make[1]: *** [arch/i386/mm/hugetlbpage.o] Error 1
> make: *** [arch/i386/mm] Error 2
>
Looks like there's a missing include, the following patch should fix it

--- arch/i386/mm/hugetlbpage.c.orig 2002-11-27 23:37:47.000000000 +0000
+++ arch/i386/mm/hugetlbpage.c 2002-11-27 23:36:20.000000000 +0000
@@ -14,6 +14,7 @@
#include <linux/slab.h>
#include <linux/module.h>
#include <linux/err.h>
+#include <linux/sysctl.h>
#include <asm/mman.h>
#include <asm/pgalloc.h>
#include <asm/tlb.h>



hth, martin

--
Martin Dahl
[email protected]

2002-11-27 23:41:34

by Frank Davis

Subject: Re: [PATCH] Re: 2.5.50 : arch/i386/mm/hugetblpage.c error

Hello all,
Changing the prototype to match include/linux/hugetlb.h also works.

Regards,
Frank

Martin Dahl wrote:
>>Hello all,
>> While 'make bzImage', I received the following error.
>>
>>Regards,
>>Frank
>>
>>arch/i386/mm/hugetlbpage.c:610: parse error before `*'
>>arch/i386/mm/hugetlbpage.c: In function `hugetlb_sysctl_handler':
>>arch/i386/mm/hugetlbpage.c:611: number of arguments doesn't match prototype
>>include/linux/hugetlb.h:14: prototype declaration
>>arch/i386/mm/hugetlbpage.c:612: warning: implicit declaration of function `proc_dointvec'
>>arch/i386/mm/hugetlbpage.c:612: `table' undeclared (first use in this function)
>>arch/i386/mm/hugetlbpage.c:612: (Each undeclared identifier is reported only once
>>arch/i386/mm/hugetlbpage.c:612: for each function it appears in.)
>>arch/i386/mm/hugetlbpage.c:612: `write' undeclared (first use in this function)
>>arch/i386/mm/hugetlbpage.c:612: `file' undeclared (first use in this function)
>>arch/i386/mm/hugetlbpage.c:612: `buffer' undeclared (first use in this function)
>>arch/i386/mm/hugetlbpage.c:612: `length' undeclared (first use in this function)
>>make[1]: *** [arch/i386/mm/hugetlbpage.o] Error 1
>>make: *** [arch/i386/mm] Error 2
>>
>
> Looks like there's a missing include, the following patch should fix it
>
> --- arch/i386/mm/hugetlbpage.c.orig 2002-11-27 23:37:47.000000000 +0000
> +++ arch/i386/mm/hugetlbpage.c 2002-11-27 23:36:20.000000000 +0000
> @@ -14,6 +14,7 @@
> #include <linux/slab.h>
> #include <linux/module.h>
> #include <linux/err.h>
> +#include <linux/sysctl.h>
> #include <asm/mman.h>
> #include <asm/pgalloc.h>
> #include <asm/tlb.h>
>
>
>
> hth, martin
>