2014-07-22 04:24:08

by Nicholas Krause

[permalink] [raw]
Subject: decompress.c : Add cache support

Hey Ralf and others
We seem to be flushing this cache after decompressing the kernel on
mips. Can't we cache this?
If anyone has any advice on how to fix this it would be great:).
Nick


2014-07-22 17:14:55

by Florian Fainelli

[permalink] [raw]
Subject: Re: decompress.c : Add cache support

2014-07-21 21:24 GMT-07:00 Nick Krause <[email protected]>:
> Hey Ralf and others
> We seem to be flushing this cache after decompressing the kernel on
> mips. Can't we cache this?

I am not sure I fully understand what you mean here. What would we be
caching, instruction, data, both?

> If anyone has any advice on how to fix this it would be great:).
> Nick

One patch that I carried locally and which works for a bunch of
MIPS32r1 compatible platforms out there is this one, I tried to
address some of Ralf's comment as well about the code duplication
(maybe I can get around to resubmit it):

http://patchwork.linux-mips.org/patch/1565/
--
Florian

2014-07-22 17:41:52

by Nicholas Krause

[permalink] [raw]
Subject: Re: decompress.c : Add cache support

On Tue, Jul 22, 2014 at 1:14 PM, Florian Fainelli <[email protected]> wrote:
> 2014-07-21 21:24 GMT-07:00 Nick Krause <[email protected]>:
>> Hey Ralf and others
>> We seem to be flushing this cache after decompressing the kernel on
>> mips. Can't we cache this?
>
> I am not sure I fully understand what you mean here. What would we be
> caching, instruction, data, both?
>
>> If anyone has any advice on how to fix this it would be great:).
>> Nick
>
> One patch that I carried locally and which works for a bunch of
> MIPS32r1 compatible platforms out there is this one, I tried to
> address some of Ralf's comment as well about the code duplication
> (maybe I can get around to resubmit it):
>
> http://patchwork.linux-mips.org/patch/1565/
> --
> Florian

Florian,
You should resubmit this patch as it seems to be correct and fix this issue.
Cheers Nick