2014-07-22 14:12:22

by Benjamin LaHaise

Subject: Re: [PATCH 3/4] aio: fix some comments

On Tue, Jul 22, 2014 at 10:40:03AM +0800, Gu Zheng wrote:
> Signed-off-by: Gu Zheng <[email protected]>

Again, you're missing a commit message here. Please resubmit with a commit
message.

-ben

> ---
> fs/aio.c | 7 +++----
> 1 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/fs/aio.c b/fs/aio.c
> index 1dc6158..0cd0479 100644
> --- a/fs/aio.c
> +++ b/fs/aio.c
> @@ -1037,7 +1037,7 @@ void aio_complete(struct kiocb *iocb, long res, long res2)
> }
> EXPORT_SYMBOL(aio_complete);
>
> -/* aio_read_events
> +/* aio_read_events_ring
> * Pull an event off of the ioctx's event ring. Returns the number of
> * events fetched
> */
> @@ -1289,9 +1289,8 @@ static ssize_t aio_setup_single_vector(struct kiocb *kiocb,
> }
>
> /*
> - * aio_setup_iocb:
> - * Performs the initial checks and aio retry method
> - * setup for the kiocb at the time of io submission.
> + * aio_run_iocb:
> + * Performs the initial checks and io submission.
> */
> static ssize_t aio_run_iocb(struct kiocb *req, unsigned opcode,
> char __user *buf, bool compat)
> --
> 1.7.7

--
"Thought is the essence of where you are now."

2014-07-23 04:10:15

by Gu Zheng

Subject: Re: [PATCH 3/4] aio: fix some comments

On 07/22/2014 10:12 PM, Benjamin LaHaise wrote:

> On Tue, Jul 22, 2014 at 10:40:03AM +0800, Gu Zheng wrote:
>> Signed-off-by: Gu Zheng <[email protected]>
>
> Again, you're missing a commit message here. Please resubmit with a commit
> message.

Got it, I'll resend it later.

Thanks,
Gu

>
> -ben
>
>> ---
>> fs/aio.c | 7 +++----
>> 1 files changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/fs/aio.c b/fs/aio.c
>> index 1dc6158..0cd0479 100644
>> --- a/fs/aio.c
>> +++ b/fs/aio.c
>> @@ -1037,7 +1037,7 @@ void aio_complete(struct kiocb *iocb, long res, long res2)
>> }
>> EXPORT_SYMBOL(aio_complete);
>>
>> -/* aio_read_events
>> +/* aio_read_events_ring
>> * Pull an event off of the ioctx's event ring. Returns the number of
>> * events fetched
>> */
>> @@ -1289,9 +1289,8 @@ static ssize_t aio_setup_single_vector(struct kiocb *kiocb,
>> }
>>
>> /*
>> - * aio_setup_iocb:
>> - * Performs the initial checks and aio retry method
>> - * setup for the kiocb at the time of io submission.
>> + * aio_run_iocb:
>> + * Performs the initial checks and io submission.
>> */
>> static ssize_t aio_run_iocb(struct kiocb *req, unsigned opcode,
>> char __user *buf, bool compat)
>> --
>> 1.7.7
>