LinuxLists.cc - [PATCH] mtd: nand: gpmi: remove deprecated comment

2014-12-02 18:37:16

Subject: [PATCH] mtd: nand: gpmi: remove deprecated comment

Now that we have raw functions properly implemented we can remove this
FIXME.

Signed-off-by: Boris Brezillon <[email protected]>
---
drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 8 --------
1 file changed, 8 deletions(-)

diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
index 4f3851a..5d2cc9e 100644
--- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
+++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
@@ -1294,14 +1294,6 @@ exit_auxiliary:
* ecc.read_page or ecc.read_page_raw function. Thus, the fact that MTD wants an
* ECC-based or raw view of the page is implicit in which function it calls
* (there is a similar pair of ECC-based/raw functions for writing).
- *
- * FIXME: The following paragraph is incorrect, now that there exist
- * ecc.read_oob_raw and ecc.write_oob_raw functions.
- *
- * Since MTD assumes the OOB is not covered by ECC, there is no pair of
- * ECC-based/raw functions for reading or or writing the OOB. The fact that the
- * caller wants an ECC-based or raw view of the page is not propagated down to
- * this driver.
*/
static int gpmi_ecc_read_oob(struct mtd_info *mtd, struct nand_chip *chip,
int page)
--
1.9.1

2014-12-03 00:30:46

by Huang Shijie

[permalink] [raw]

Subject: Re: [PATCH] mtd: nand: gpmi: remove deprecated comment

On Tue, Dec 02, 2014 at 07:37:09PM +0100, Boris Brezillon wrote:
> Now that we have raw functions properly implemented we can remove this
> FIXME.
>
> Signed-off-by: Boris Brezillon <[email protected]>
> ---
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> index 4f3851a..5d2cc9e 100644
> --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> @@ -1294,14 +1294,6 @@ exit_auxiliary:
> * ecc.read_page or ecc.read_page_raw function. Thus, the fact that MTD wants an
> * ECC-based or raw view of the page is implicit in which function it calls
> * (there is a similar pair of ECC-based/raw functions for writing).
> - *
> - * FIXME: The following paragraph is incorrect, now that there exist
> - * ecc.read_oob_raw and ecc.write_oob_raw functions.
> - *
> - * Since MTD assumes the OOB is not covered by ECC, there is no pair of
> - * ECC-based/raw functions for reading or or writing the OOB. The fact that the
> - * caller wants an ECC-based or raw view of the page is not propagated down to
> - * this driver.
> */
> static int gpmi_ecc_read_oob(struct mtd_info *mtd, struct nand_chip *chip,
> int page)
Acked-by: Huang Shijie <[email protected]>

2014-12-17 01:27:51

by Brian Norris

[permalink] [raw]