Linus,
James Bottomley confirmed the "deprecated" attribute requires gcc 3.1
and onward, not gcc 3.0.
Attached patch updates the check in compiler.h to require gcc 3.1 or
greater.
Patch is against current BK, please apply.
Robert Love
include/linux/compiler.h | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff -urN linux-2.5.53/include/linux/compiler.h linux/include/linux/compiler.h
--- linux-2.5.53/include/linux/compiler.h~ 2002-12-31 17:27:53.000000000 -0500
+++ linux/include/linux/compiler.h 2002-12-31 17:29:09.000000000 -0500
@@ -17,10 +17,9 @@
* Allow us to mark functions as 'deprecated' and have gcc emit a nice
* warning for each use, in hopes of speeding the functions removal.
* Usage is:
- * int deprecated foo(void)
- * and then gcc will emit a warning for each usage of the function.
+ * int __deprecated foo(void)
*/
-#if __GNUC__ >= 3
+#if ( __GNUC__ == 3 && __GNUC_MINOR > 0 ) || __GNUC__ > 3
#define __deprecated __attribute__((deprecated))
#else
#define __deprecated
Oops, mea culpa on that one. It's missing a trailing `__' on the end of
__GNUC_MINOR
James
On Tue, 2002-12-31 at 18:13, James Bottomley wrote:
> Oops, mea culpa on that one. It's missing a trailing `__' on the end of
> __GNUC_MINOR
Looks like Linus already committed it.
Attached patch is against the updated BK and fixes the omission. Sorry.
Robert Love
include/linux/compiler.h | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -urN linux-2.5.53/include/linux/compiler.h linux/include/linux/compiler.h
--- linux-2.5.53/include/linux/compiler.h 2002-12-31 18:39:55.000000000 -0500
+++ linux/include/linux/compiler.h 2002-12-31 18:40:10.000000000 -0500
@@ -19,7 +19,7 @@
* Usage is:
* int __deprecated foo(void)
*/
-#if ( __GNUC__ == 3 && __GNUC_MINOR > 0 ) || __GNUC__ > 3
+#if ( __GNUC__ == 3 && __GNUC_MINOR__ > 0 ) || __GNUC__ > 3
#define __deprecated __attribute__((deprecated))
#else
#define __deprecated