2014-12-16 07:27:58

by Ley Foon Tan

Subject: [PATCH] serial: altera-juart: fix NULL device in log message

Add device pointer to port->dev.

Before:

"(NULL device *): ttyJ0 at MMIO 0x1008 (irq = 2, base_baud = 0) is a
Altera JTAG UART"

After:
"altera_jtaguart 1008.serial: ttyJ0 at MMIO 0x1008 (irq = 2, base_baud = 0) is a
Altera JTAG UART"

Signed-off-by: Ley Foon Tan <[email protected]>
---
drivers/tty/serial/altera_jtaguart.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/tty/serial/altera_jtaguart.c b/drivers/tty/serial/altera_jtaguart.c
index 192d043..0fefdd8 100644
--- a/drivers/tty/serial/altera_jtaguart.c
+++ b/drivers/tty/serial/altera_jtaguart.c
@@ -441,6 +441,7 @@ static int altera_jtaguart_probe(struct platform_device *pdev)
port->iotype = SERIAL_IO_MEM;
port->ops = &altera_jtaguart_ops;
port->flags = UPF_BOOT_AUTOCONF;
+ port->dev = &pdev->dev;

uart_add_one_port(&altera_jtaguart_driver, port);

--
1.8.2.1

2014-12-16 08:00:21

by Tobias Klauser

Subject: Re: [PATCH] serial: altera-juart: fix NULL device in log message

On 2014-12-16 at 08:27:46 +0100, Ley Foon Tan <[email protected]> wrote:
> Add device pointer to port->dev.
>
> Before:
>
> "(NULL device *): ttyJ0 at MMIO 0x1008 (irq = 2, base_baud = 0) is a
> Altera JTAG UART"
>
> After:
> "altera_jtaguart 1008.serial: ttyJ0 at MMIO 0x1008 (irq = 2, base_baud = 0) is a
> Altera JTAG UART"
>
> Signed-off-by: Ley Foon Tan <[email protected]>

Acked-by: Tobias Klauser <[email protected]>