2014-12-21 14:22:26

by Fengguang Wu

Subject: [PATCH] Thermal: fix platform_no_drv_owner.cocci warnings

drivers/thermal/int340x_thermal/int3402_thermal.c:234:6-11: No need to set .owner here. The core will do it.

Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

CC: Aaron Lu <[email protected]>
Signed-off-by: Fengguang Wu <[email protected]>
---

int3402_thermal.c | 1 -
1 file changed, 1 deletion(-)

--- a/drivers/thermal/int340x_thermal/int3402_thermal.c
+++ b/drivers/thermal/int340x_thermal/int3402_thermal.c
@@ -231,7 +231,6 @@ static struct platform_driver int3402_th
.remove = int3402_thermal_remove,
.driver = {
.name = "int3402 thermal",
- .owner = THIS_MODULE,
.acpi_match_table = int3402_thermal_match,
},
};

2014-12-22 01:54:45

by Aaron Lu

Subject: Re: [PATCH] Thermal: fix platform_no_drv_owner.cocci warnings

On 12/21/2014 10:21 PM, kbuild test robot wrote:
> drivers/thermal/int340x_thermal/int3402_thermal.c:234:6-11: No need to set .owner here. The core will do it.
>
> Remove .owner field if calls are used which set it automatically
>
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>
> CC: Aaron Lu <[email protected]>
> Signed-off-by: Fengguang Wu <[email protected]>

Looks good to me, thanks!

-Aaron

> ---
>
> int3402_thermal.c | 1 -
> 1 file changed, 1 deletion(-)
>
> --- a/drivers/thermal/int340x_thermal/int3402_thermal.c
> +++ b/drivers/thermal/int340x_thermal/int3402_thermal.c
> @@ -231,7 +231,6 @@ static struct platform_driver int3402_th
> .remove = int3402_thermal_remove,
> .driver = {
> .name = "int3402 thermal",
> - .owner = THIS_MODULE,
> .acpi_match_table = int3402_thermal_match,
> },
> };
>