2015-02-12 22:11:52

by Luis de Bethencourt

Subject: [PATCH] dib0700: remove unused macros

Remove unused macros RC_REPEAT_DELAY and RC_REPEAT_DELAY_V1_20

Signed-off-by: Luis de Bethencourt <[email protected]>
---
drivers/media/usb/dvb-usb/dib0700_core.c | 3 ---
drivers/media/usb/dvb-usb/dib0700_devices.c | 3 ---
2 files changed, 6 deletions(-)

diff --git a/drivers/media/usb/dvb-usb/dib0700_core.c b/drivers/media/usb/dvb-usb/dib0700_core.c
index 50856db..2b40393 100644
--- a/drivers/media/usb/dvb-usb/dib0700_core.c
+++ b/drivers/media/usb/dvb-usb/dib0700_core.c
@@ -651,9 +651,6 @@ out:
return ret;
}

-/* Number of keypresses to ignore before start repeating */
-#define RC_REPEAT_DELAY_V1_20 10
-
/* This is the structure of the RC response packet starting in firmware 1.20 */
struct dib0700_rc_response {
u8 report_id;
diff --git a/drivers/media/usb/dvb-usb/dib0700_devices.c b/drivers/media/usb/dvb-usb/dib0700_devices.c
index e1757b8..d7d55a2 100644
--- a/drivers/media/usb/dvb-usb/dib0700_devices.c
+++ b/drivers/media/usb/dvb-usb/dib0700_devices.c
@@ -510,9 +510,6 @@ static int stk7700ph_tuner_attach(struct dvb_usb_adapter *adap)

static u8 rc_request[] = { REQUEST_POLL_RC, 0 };

-/* Number of keypresses to ignore before start repeating */
-#define RC_REPEAT_DELAY 6
-
/*
* This function is used only when firmware is < 1.20 version. Newer
* firmwares use bulk mode, with functions implemented at dib0700_core,
--
2.1.0

2015-02-12 23:38:31

by Luis de Bethencourt

Subject: Re: [PATCH] dib0700: remove unused macros

On Thu, Feb 12, 2015 at 10:11:47PM +0000, Luis de Bethencourt wrote:
> Remove unused macros RC_REPEAT_DELAY and RC_REPEAT_DELAY_V1_20
>
> Signed-off-by: Luis de Bethencourt <[email protected]>
> ---
> drivers/media/usb/dvb-usb/dib0700_core.c | 3 ---
> drivers/media/usb/dvb-usb/dib0700_devices.c | 3 ---
> 2 files changed, 6 deletions(-)
>
> diff --git a/drivers/media/usb/dvb-usb/dib0700_core.c b/drivers/media/usb/dvb-usb/dib0700_core.c
> index 50856db..2b40393 100644
> --- a/drivers/media/usb/dvb-usb/dib0700_core.c
> +++ b/drivers/media/usb/dvb-usb/dib0700_core.c
> @@ -651,9 +651,6 @@ out:
> return ret;
> }
>
> -/* Number of keypresses to ignore before start repeating */
> -#define RC_REPEAT_DELAY_V1_20 10
> -
> /* This is the structure of the RC response packet starting in firmware 1.20 */
> struct dib0700_rc_response {
> u8 report_id;
> diff --git a/drivers/media/usb/dvb-usb/dib0700_devices.c b/drivers/media/usb/dvb-usb/dib0700_devices.c
> index e1757b8..d7d55a2 100644
> --- a/drivers/media/usb/dvb-usb/dib0700_devices.c
> +++ b/drivers/media/usb/dvb-usb/dib0700_devices.c
> @@ -510,9 +510,6 @@ static int stk7700ph_tuner_attach(struct dvb_usb_adapter *adap)
>
> static u8 rc_request[] = { REQUEST_POLL_RC, 0 };
>
> -/* Number of keypresses to ignore before start repeating */
> -#define RC_REPEAT_DELAY 6
> -
> /*
> * This function is used only when firmware is < 1.20 version. Newer
> * firmwares use bulk mode, with functions implemented at dib0700_core,
> --
> 2.1.0
>

For some context, the only usage of macro RC_REPEAT_DELAY_V1_20 was removed in
commit 72b393106bddc9f0a1ab502b4c8c5793a0441a30

And the last usage of macro RC_REPEAT_DELAY was removed in commit
72b393106bddc9f0a1ab502b4c8c5793a0441a30

Thanks,
Luis