2015-02-18 19:10:38

by Alexander Kuleshov

[permalink] [raw]
Subject: [PATCH 1/3] fs/fat: remove unnecessary defintion

'*sb' never used, so let's remote it and pass inode->i_sb directly to
the MSDOS_SB.

Signed-off-by: Alexander Kuleshov <[email protected]>
---
fs/fat/inode.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/fat/inode.c b/fs/fat/inode.c
index 7b41a2d..e140e62 100644
--- a/fs/fat/inode.c
+++ b/fs/fat/inode.c
@@ -1280,8 +1280,7 @@ out:

static int fat_read_root(struct inode *inode)
{
- struct super_block *sb = inode->i_sb;
- struct msdos_sb_info *sbi = MSDOS_SB(sb);
+ struct msdos_sb_info *sbi = MSDOS_SB(inode->i_sb);
int error;

MSDOS_I(inode)->i_pos = MSDOS_ROOT_INO;
--
2.3.0.401.g57a267c.dirty


2015-02-18 19:11:25

by Alexander Kuleshov

[permalink] [raw]
Subject: Re: [PATCH 1/3] fs/fat: remove unnecessary defintion

Sorry for noise. Sent wrong patch.

2015-02-19 1:10 GMT+06:00 Alexander Kuleshov <[email protected]>:
> '*sb' never used, so let's remote it and pass inode->i_sb directly to
> the MSDOS_SB.
>
> Signed-off-by: Alexander Kuleshov <[email protected]>
> ---
> fs/fat/inode.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/fat/inode.c b/fs/fat/inode.c
> index 7b41a2d..e140e62 100644
> --- a/fs/fat/inode.c
> +++ b/fs/fat/inode.c
> @@ -1280,8 +1280,7 @@ out:
>
> static int fat_read_root(struct inode *inode)
> {
> - struct super_block *sb = inode->i_sb;
> - struct msdos_sb_info *sbi = MSDOS_SB(sb);
> + struct msdos_sb_info *sbi = MSDOS_SB(inode->i_sb);
> int error;
>
> MSDOS_I(inode)->i_pos = MSDOS_ROOT_INO;
> --
> 2.3.0.401.g57a267c.dirty
>



--
_________________________
0xAX