2015-04-01 16:19:38

by Madalin-Cristian Bucur

[permalink] [raw]
Subject: [PATCH RFC 00/10] introduce DPAA Ethernet driver

This is the second version of a patch series that adds
the Ethernet driver for the Freescale QorIQ Data Path
Acceleration Architecture (DPAA).

This second version includes the changes requested by
Kumar Gala. The PM ops patch was removed as the
supporting FMan driver code was de-featured from the
first submission of the driver to reduce the review
effort.

Together with the driver a managed version of alloc_percpu
is provided that simplifies the release of percpu memory.

The Freescale DPAA architecture consists in a series of
hardware blocks that support the Ethernet connectivity.
the Ethernet driver depends upon the Peripheral Access
Memory Unit (PAMU), Frame Manager (FMan), Queue Manager
(QMan), Buffer Manager (BMan). Drivers for these blocks
are currently in the kernel or in review.

The current set of RFC patches is meant to provide early
access to the codebase and also provide context and aid
the review of the latest FMan driver patches submitted
by Igal Liberman:

[RFC,v2,12/12] soc/fman: Add FMan MAC driver
[RFC,v2,11/12] soc/fman: Add FMan Port Support
[RFC,v2,10/12] soc/fman: Add FMan SP support
[RFC,v2,09/12] soc/fman: Add FMan MAC support
[RFC,v2,08/12] soc/fman: Add Frame Manager support
[RFC,v2,07/12] soc/fman: Add FMan MURAM support
[RFC,v2,06/12] soc/fman: Add the FMan MAC FLIB
[RFC,v2,05/12] soc/fman: Add the FMan MAC FLIB headers
[RFC,v2,04/12] soc/fman: Add the FMan port FLIB
[RFC,v2,03/12] soc/fman: Add the FMan port FLIB headers
[RFC,v2,02/12] soc/fman: Add the FMan FLIB
[RFC,v2,01/12] soc/fman: Add the FMan FLIB headers

https://patchwork.ozlabs.org/project/linuxppc-dev/list/?submitter=Igal.Liberman&state=*&q=RFC%2Cv2

These patches rely also on the Q/BMan drivers submitted by
Emil Medve:

[RFC,v3,10/10] fsl_qman: Add HOTPLUG_CPU support
[RFC,v3,09/10] fsl_bman: Add HOTPLUG_CPU support
[RFC,v3,08/10] fsl_qman: Add debugfs support
[RFC,v3,07/10] fsl_bman: Add debugfs support
[RFC,v3,06/10] fsl_qman: Add self-tester
[RFC,v3,05/10] fsl_bman: Add self-tester
[RFC,v3,04/10] powerpc/mpc85xx: Add platform support for the Freescale DPAA QMan
[RFC,v3,03/10] powerpc/mpc85xx: Add platform support for the Freescale DPAA BMan
[RFC,v3,02/10] fsl_qman: Add drivers for the Freescale DPAA QMan
[RFC,v3,01/10] fsl_bman: Add drivers for the Freescale DPAA BMan

https://patchwork.ozlabs.org/project/linuxppc-dev/list/?submitter=Emil+Medve&state=*&q=RFC

The DPAA Ethernet driver is the result of the collaborative
work of many individuals, to name a few:
Andy Fleming
Emil Medve
Kumar Gala
Ioana Radulescu
Bogdan Hamciuc
Madalin Bucur
Cristian Sovaiala
Marian Rotariu
Andrei Pistirica
Cristian Bercaru

The current patch set is the result of a sustained clean-up
and adaptation work on the QorIQ DPAA drivers released in
the open source Freescale SDK. The SDK drivers differ as they
offer support for advanced accelerations and other features
that are not upstreamable. The SDK Ethernet driver is based
on a different, non-upstreamable variant of the FMan driver.
The short term goal is to provide basic Ethernet support in
the vanilla kernel then to gradually increase the feature set.

The SDK documentation and source code, documentation for the
DPAA hardware are available from the company website.

Madalin Bucur (10):
devres: add devm_alloc_percpu()
dpaa_eth: add support for DPAA Ethernet
dpaa_eth: add configurable bpool thresholds
dpaa_eth: add support for S/G frames
dpaa_eth: add driver's Tx queue selection mechanism
dpaa_eth: add ethtool functionality
dpaa_eth: add sysfs exports
dpaa_eth: add debugfs counters
dpaa_eth: add debugfs entries
dpaa_eth: add trace points

Documentation/driver-model/devres.txt | 4 +
drivers/base/devres.c | 63 +
drivers/net/ethernet/freescale/Kconfig | 2 +
drivers/net/ethernet/freescale/Makefile | 1 +
drivers/net/ethernet/freescale/dpaa/Kconfig | 87 ++
drivers/net/ethernet/freescale/dpaa/Makefile | 17 +
drivers/net/ethernet/freescale/dpaa/dpaa_debugfs.c | 273 ++++
drivers/net/ethernet/freescale/dpaa/dpaa_debugfs.h | 43 +
drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 881 +++++++++++++
drivers/net/ethernet/freescale/dpaa/dpaa_eth.h | 495 +++++++
.../net/ethernet/freescale/dpaa/dpaa_eth_common.c | 1387 ++++++++++++++++++++
.../net/ethernet/freescale/dpaa/dpaa_eth_common.h | 130 ++
drivers/net/ethernet/freescale/dpaa/dpaa_eth_sg.c | 725 ++++++++++
.../net/ethernet/freescale/dpaa/dpaa_eth_sysfs.c | 168 +++
.../net/ethernet/freescale/dpaa/dpaa_eth_trace.h | 143 ++
drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c | 254 ++++
include/linux/device.h | 19 +
17 files changed, 4692 insertions(+)
create mode 100644 drivers/net/ethernet/freescale/dpaa/Kconfig
create mode 100644 drivers/net/ethernet/freescale/dpaa/Makefile
create mode 100644 drivers/net/ethernet/freescale/dpaa/dpaa_debugfs.c
create mode 100644 drivers/net/ethernet/freescale/dpaa/dpaa_debugfs.h
create mode 100644 drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
create mode 100644 drivers/net/ethernet/freescale/dpaa/dpaa_eth.h
create mode 100644 drivers/net/ethernet/freescale/dpaa/dpaa_eth_common.c
create mode 100644 drivers/net/ethernet/freescale/dpaa/dpaa_eth_common.h
create mode 100644 drivers/net/ethernet/freescale/dpaa/dpaa_eth_sg.c
create mode 100644 drivers/net/ethernet/freescale/dpaa/dpaa_eth_sysfs.c
create mode 100644 drivers/net/ethernet/freescale/dpaa/dpaa_eth_trace.h
create mode 100644 drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c

--
1.7.11.7


2015-04-02 11:13:07

by Valentin Longchamp

[permalink] [raw]
Subject: Re: [PATCH RFC 00/10] introduce DPAA Ethernet driver

On 04/01/2015 06:19 PM, Madalin Bucur wrote:
> This is the second version of a patch series that adds
> the Ethernet driver for the Freescale QorIQ Data Path
> Acceleration Architecture (DPAA).
>
> This second version includes the changes requested by
> Kumar Gala. The PM ops patch was removed as the
> supporting FMan driver code was de-featured from the
> first submission of the driver to reduce the review
> effort.
>
> Together with the driver a managed version of alloc_percpu
> is provided that simplifies the release of percpu memory.
>
> The Freescale DPAA architecture consists in a series of
> hardware blocks that support the Ethernet connectivity.
> the Ethernet driver depends upon the Peripheral Access
> Memory Unit (PAMU), Frame Manager (FMan), Queue Manager
> (QMan), Buffer Manager (BMan). Drivers for these blocks
> are currently in the kernel or in review.
>
> The current set of RFC patches is meant to provide early
> access to the codebase and also provide context and aid
> the review of the latest FMan driver patches submitted
> by Igal Liberman:
>
> [RFC,v2,12/12] soc/fman: Add FMan MAC driver
> [RFC,v2,11/12] soc/fman: Add FMan Port Support
> [RFC,v2,10/12] soc/fman: Add FMan SP support
> [RFC,v2,09/12] soc/fman: Add FMan MAC support
> [RFC,v2,08/12] soc/fman: Add Frame Manager support
> [RFC,v2,07/12] soc/fman: Add FMan MURAM support
> [RFC,v2,06/12] soc/fman: Add the FMan MAC FLIB
> [RFC,v2,05/12] soc/fman: Add the FMan MAC FLIB headers
> [RFC,v2,04/12] soc/fman: Add the FMan port FLIB
> [RFC,v2,03/12] soc/fman: Add the FMan port FLIB headers
> [RFC,v2,02/12] soc/fman: Add the FMan FLIB
> [RFC,v2,01/12] soc/fman: Add the FMan FLIB headers
>
> https://patchwork.ozlabs.org/project/linuxppc-dev/list/?submitter=Igal.Liberman&state=*&q=RFC%2Cv2
>
> These patches rely also on the Q/BMan drivers submitted by
> Emil Medve:
>
> [RFC,v3,10/10] fsl_qman: Add HOTPLUG_CPU support
> [RFC,v3,09/10] fsl_bman: Add HOTPLUG_CPU support
> [RFC,v3,08/10] fsl_qman: Add debugfs support
> [RFC,v3,07/10] fsl_bman: Add debugfs support
> [RFC,v3,06/10] fsl_qman: Add self-tester
> [RFC,v3,05/10] fsl_bman: Add self-tester
> [RFC,v3,04/10] powerpc/mpc85xx: Add platform support for the Freescale DPAA QMan
> [RFC,v3,03/10] powerpc/mpc85xx: Add platform support for the Freescale DPAA BMan
> [RFC,v3,02/10] fsl_qman: Add drivers for the Freescale DPAA QMan
> [RFC,v3,01/10] fsl_bman: Add drivers for the Freescale DPAA BMan
>
> https://patchwork.ozlabs.org/project/linuxppc-dev/list/?submitter=Emil+Medve&state=*&q=RFC
>

Hello Madalin,

Thank you very much for this summary that helps keeping an overview on the
current Freescale mainline DPAA effort (by the way, I am also very pleased to
see these patches getting to the mailing-lists, this is very important to us).

Now I would like to give all this a try on our P2041 board, the kmcoge4 for
which there is a DT in mainline. Could you please tell me on what kernel branch
these patches are based on ?

Best Regards

Valentin