2015-04-06 01:55:25

by Brian Norris

[permalink] [raw]
Subject: Re: [PATCH v2] mtd: Make MTD tests cancelable

On Sun, Mar 29, 2015 at 09:52:06PM +0200, Richard Weinberger wrote:
> I always go nuts when I start an MTD test on a slow device
> and have to wait forever until it finishes.

As do I.

As an additional measure, I'm tempted to add an 'ebcnt' parameter for
some of the tests that don't have them, for when I want a quicker test.

> From the debug output I already know what the issue is but I
> have to wait or reset the board hard.
> Resetting is often not an option
> (remote access, you don't want lose the current state, etc...).
>
> The solution is easy, check for pending signals at key positions
> in the code. Using that one can even stop a test by pressing CTRL-C
> as insmod/modprobe have SIGINT pending.
>
> Signed-off-by: Richard Weinberger <[email protected]>
> ---
> v2: First patch was missing two hunks from my working tree.
> git commit -a vs. git commit ;-\

Awesome! Pushed to l2-mtd.git. Thanks.

Brian