2015-04-24 08:27:42

by Tobias Klauser

Subject: [PATCH] ARC: perf: Remove unnecessary local variable

Directly return the result of perf_pmu_register() in
arc_pmu_device_probe() instead of assigning and returning variable ret.

Signed-off-by: Tobias Klauser <[email protected]>
---
arch/arc/kernel/perf_event.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/arc/kernel/perf_event.c b/arch/arc/kernel/perf_event.c
index fd2ec50..eea8a7b 100644
--- a/arch/arc/kernel/perf_event.c
+++ b/arch/arc/kernel/perf_event.c
@@ -269,7 +269,7 @@ static int arc_pmu_device_probe(struct platform_device *pdev)
struct arc_pmu *arc_pmu;
struct arc_reg_pct_build pct_bcr;
struct arc_reg_cc_build cc_bcr;
- int i, j, ret;
+ int i, j;

union cc_name {
struct {
@@ -336,9 +336,7 @@ static int arc_pmu_device_probe(struct platform_device *pdev)
/* ARC 700 PMU does not support sampling events */
arc_pmu->pmu.capabilities |= PERF_PMU_CAP_NO_INTERRUPT;

- ret = perf_pmu_register(&arc_pmu->pmu, pdev->name, PERF_TYPE_RAW);
-
- return ret;
+ return perf_pmu_register(&arc_pmu->pmu, pdev->name, PERF_TYPE_RAW);
}

#ifdef CONFIG_OF
--
2.2.2

2015-06-06 12:48:34

by Vineet Gupta

Subject: Re: [PATCH] ARC: perf: Remove unnecessary local variable

On Friday 24 April 2015 01:57 PM, Tobias Klauser wrote:
> Directly return the result of perf_pmu_register() in
> arc_pmu_device_probe() instead of assigning and returning variable ret.
>
> Signed-off-by: Tobias Klauser <[email protected]>

Applied to ARC for-next

Thx Tobias,
-Vineet