2015-05-11 22:47:47

by Asai Thambi SP

[permalink] [raw]
Subject: [PATCH 0/9] mtip32xx: various fixes

Hi Jens,

This patchset includes few changes to align with recent kernel changes, few
fixes and cleanup

Asai Thambi S P (9):
mtip32xx: fix rmmod issue
mtip32xx: remove unused variable 'port->allocated'
mtip32xx: fix incorrectly setting MTIP_DDF_SEC_LOCK_BIT
mtip32xx: Abort I/O during secure erase operation
mtip32xx: fix crash on surprise removal of the drive
mtip32xx: remove unnecessary sleep in mtip_ftl_rebuild_poll()
mtip32xx: fix minor number
mtip32xx: abort secure erase operation if the device is mounted
mtip32xx: increase wait time for hba reset

drivers/block/mtip32xx/mtip32xx.c | 223 ++++++++++++++++---------------------
drivers/block/mtip32xx/mtip32xx.h | 8 +-
2 files changed, 98 insertions(+), 133 deletions(-)


2015-05-12 15:39:17

by Jens Axboe

[permalink] [raw]
Subject: Re: [PATCH 0/9] mtip32xx: various fixes

On 05/11/2015 06:47 PM, Asai Thambi SP wrote:
> Hi Jens,
>
> This patchset includes few changes to align with recent kernel changes, few
> fixes and cleanup
>
> Asai Thambi S P (9):
> mtip32xx: fix rmmod issue
> mtip32xx: remove unused variable 'port->allocated'
> mtip32xx: fix incorrectly setting MTIP_DDF_SEC_LOCK_BIT
> mtip32xx: Abort I/O during secure erase operation
> mtip32xx: fix crash on surprise removal of the drive
> mtip32xx: remove unnecessary sleep in mtip_ftl_rebuild_poll()
> mtip32xx: fix minor number
> mtip32xx: abort secure erase operation if the device is mounted
> mtip32xx: increase wait time for hba reset

Have these been through one of your qual cycles? Just wondering if I
should attempt to squeeze this into the current series, or wait for 4.2.


--
Jens Axboe

2015-05-13 00:35:10

by Asai Thambi SP

[permalink] [raw]
Subject: Re: [PATCH 0/9] mtip32xx: various fixes

On 5/12/2015 8:39 AM, Jens Axboe wrote:
> On 05/11/2015 06:47 PM, Asai Thambi SP wrote:
>> Hi Jens,
>>
>> This patchset includes few changes to align with recent kernel changes, few
>> fixes and cleanup
>>
>> Asai Thambi S P (9):
>> mtip32xx: fix rmmod issue
>> mtip32xx: remove unused variable 'port->allocated'
>> mtip32xx: fix incorrectly setting MTIP_DDF_SEC_LOCK_BIT
>> mtip32xx: Abort I/O during secure erase operation
>> mtip32xx: fix crash on surprise removal of the drive
>> mtip32xx: remove unnecessary sleep in mtip_ftl_rebuild_poll()
>> mtip32xx: fix minor number
>> mtip32xx: abort secure erase operation if the device is mounted
>> mtip32xx: increase wait time for hba reset
>
> Have these been through one of your qual cycles? Just wondering if I should attempt to squeeze this into the current series, or wait for 4.2.
>
Yes, we have tested. You can include in the current series.

--
Regards,
Asai


2015-06-16 14:24:41

by Jens Axboe

[permalink] [raw]
Subject: Re: [PATCH 0/9] mtip32xx: various fixes

On 05/12/2015 06:35 PM, Asai Thambi SP wrote:
> On 5/12/2015 8:39 AM, Jens Axboe wrote:
>> On 05/11/2015 06:47 PM, Asai Thambi SP wrote:
>>> Hi Jens,
>>>
>>> This patchset includes few changes to align with recent kernel changes, few
>>> fixes and cleanup
>>>
>>> Asai Thambi S P (9):
>>> mtip32xx: fix rmmod issue
>>> mtip32xx: remove unused variable 'port->allocated'
>>> mtip32xx: fix incorrectly setting MTIP_DDF_SEC_LOCK_BIT
>>> mtip32xx: Abort I/O during secure erase operation
>>> mtip32xx: fix crash on surprise removal of the drive
>>> mtip32xx: remove unnecessary sleep in mtip_ftl_rebuild_poll()
>>> mtip32xx: fix minor number
>>> mtip32xx: abort secure erase operation if the device is mounted
>>> mtip32xx: increase wait time for hba reset
>>
>> Have these been through one of your qual cycles? Just wondering if I should attempt to squeeze this into the current series, or wait for 4.2.
>>
> Yes, we have tested. You can include in the current series.

I will apply 1-7, and 9. 8 you promised you'd look into a cleaner solution.


--
Jens Axboe

2015-06-16 16:40:56

by Asai Thambi SP

[permalink] [raw]
Subject: Re: [PATCH 0/9] mtip32xx: various fixes



On 6/16/2015 7:23 AM, Jens Axboe wrote:
> On 05/12/2015 06:35 PM, Asai Thambi SP wrote:
>> On 5/12/2015 8:39 AM, Jens Axboe wrote:
>>> On 05/11/2015 06:47 PM, Asai Thambi SP wrote:
>>>> Hi Jens,
>>>>
>>>> This patchset includes few changes to align with recent kernel changes, few
>>>> fixes and cleanup
>>>>
>>>> Asai Thambi S P (9):
>>>> mtip32xx: fix rmmod issue
>>>> mtip32xx: remove unused variable 'port->allocated'
>>>> mtip32xx: fix incorrectly setting MTIP_DDF_SEC_LOCK_BIT
>>>> mtip32xx: Abort I/O during secure erase operation
>>>> mtip32xx: fix crash on surprise removal of the drive
>>>> mtip32xx: remove unnecessary sleep in mtip_ftl_rebuild_poll()
>>>> mtip32xx: fix minor number
>>>> mtip32xx: abort secure erase operation if the device is mounted
>>>> mtip32xx: increase wait time for hba reset
>>>
>>> Have these been through one of your qual cycles? Just wondering if I should attempt to squeeze this into the current series, or wait for 4.2.
>>>
>> Yes, we have tested. You can include in the current series.
>
> I will apply 1-7, and 9. 8 you promised you'd look into a cleaner solution.
Thanks Jens. We made a cleaner solution for 8 and testing it.

--
Regards,
Asai