All,
In order for the timer_cyclone.c code to be enabled, the following
issues need to be remedied.
1) fast_gettimeoffset_quotient (initialized in timer_tsc->init()) is
used outside of timer_tsc.c Thus it either needs to be made static or
initialized in timer_cyclone.c
2) cpu_khz is only initialized in timer_tsc->init(). Either timer_tsc
needs to initialize in timer_tsc as well, or it needs to be initialized
outside the timer subsystem.
Now I have more "proper" patches for these issues, which makes
fast_gettimeoffset_quotient static and initializes cpu_khz in
cpu/common.c (which could be later expanded to making cpu_khz per-cpu).
However these patches move a reasonable amount of code around and touch
generic code in a number of places. So instead I've created this patch
as a "quick-fix" by duplicating some of the timer_tsc->init() code into
timer_cyclone->init(). This way we can still enable the timer_cyclone
code w/o touching any generic code (well, I do have to un-static
calibrate_tsc())
Honestly, I'm not super happy about doing it this way, but I do realize
the slush needs to thicken. However, I will continue to push the cleanup
patches, but this way the cyclone code won't depend on them.
Comments, suggestions and flames welcome.
thanks
-john
diff -Nru a/arch/i386/kernel/timers/timer_cyclone.c b/arch/i386/kernel/timers/timer_cyclone.c
--- a/arch/i386/kernel/timers/timer_cyclone.c Wed Jan 22 13:35:09 2003
+++ b/arch/i386/kernel/timers/timer_cyclone.c Wed Jan 22 13:35:09 2003
@@ -17,7 +17,7 @@
#include <asm/fixmap.h>
extern spinlock_t i8253_lock;
-
+extern unsigned long fast_gettimeoffset_quotient;
/* Number of usecs that the last interrupt was delayed */
static int delay_at_last_interrupt;
@@ -142,6 +142,28 @@
printk(KERN_ERR "Summit chipset: Counter not counting! DISABLED\n");
cyclone_timer = 0;
return -ENODEV;
+ }
+ }
+
+ /* init fast_gettimeoffset_quotent and cpu_khz.
+ * XXX - This should really be done elsewhere,
+ * and in a more generic fashion. [email protected]
+ */
+ if (cpu_has_tsc) {
+ unsigned long tsc_quotient = calibrate_tsc();
+ if (tsc_quotient) {
+ fast_gettimeoffset_quotient = tsc_quotient;
+ /* report CPU clock rate in Hz.
+ * The formula is (10^6 * 2^32) / (2^32 * 1 / (clocks/us)) =
+ * clock/second. Our precision is about 100 ppm.
+ */
+ { unsigned long eax=0, edx=1000;
+ __asm__("divl %2"
+ :"=a" (cpu_khz), "=d" (edx)
+ :"r" (tsc_quotient),
+ "0" (eax), "1" (edx));
+ printk("Detected %lu.%03lu MHz processor.\n", cpu_khz / 1000, cpu_khz % 1000);
+ }
}
}
diff -Nru a/arch/i386/kernel/timers/timer_tsc.c b/arch/i386/kernel/timers/timer_tsc.c
--- a/arch/i386/kernel/timers/timer_tsc.c Wed Jan 22 13:35:09 2003
+++ b/arch/i386/kernel/timers/timer_tsc.c Wed Jan 22 13:35:09 2003
@@ -130,7 +130,7 @@
#define CALIBRATE_LATCH (5 * LATCH)
#define CALIBRATE_TIME (5 * 1000020/HZ)
-static unsigned long __init calibrate_tsc(void)
+unsigned long __init calibrate_tsc(void)
{
/* Set the Gate high, disable speaker */
outb((inb(0x61) & ~0x02) | 0x01, 0x61);
All,
This patch (to be applied ontop of cyclone-fixes_A0) enables the
timer_cyclone.c code for the x440.
Comments, suggestions and flames welcome.
thanks
-john
diff -Nru a/arch/i386/kernel/timers/Makefile b/arch/i386/kernel/timers/Makefile
--- a/arch/i386/kernel/timers/Makefile Tue Jan 21 18:14:45 2003
+++ b/arch/i386/kernel/timers/Makefile Tue Jan 21 18:14:45 2003
@@ -4,4 +4,4 @@
obj-y := timer.o timer_none.o timer_tsc.o timer_pit.o
-obj-$(CONFIG_X86_CYCLONE) += timer_cyclone.o
+obj-$(CONFIG_X86_SUMMIT) += timer_cyclone.o
diff -Nru a/arch/i386/kernel/timers/timer.c b/arch/i386/kernel/timers/timer.c
--- a/arch/i386/kernel/timers/timer.c Tue Jan 21 18:14:45 2003
+++ b/arch/i386/kernel/timers/timer.c Tue Jan 21 18:14:45 2003
@@ -4,9 +4,14 @@
/* list of externed timers */
extern struct timer_opts timer_pit;
extern struct timer_opts timer_tsc;
-
+#ifdef CONFIG_X86_SUMMIT
+extern struct timer_opts timer_cyclone;
+#endif
/* list of timers, ordered by preference, NULL terminated */
static struct timer_opts* timers[] = {
+#ifdef CONFIG_X86_SUMMIT
+ &timer_cyclone,
+#endif
&timer_tsc,
&timer_pit,
NULL,
diff -Nru a/include/asm-i386/fixmap.h b/include/asm-i386/fixmap.h
--- a/include/asm-i386/fixmap.h Tue Jan 21 18:14:45 2003
+++ b/include/asm-i386/fixmap.h Tue Jan 21 18:14:45 2003
@@ -60,7 +60,7 @@
#ifdef CONFIG_X86_F00F_BUG
FIX_F00F_IDT, /* Virtual mapping for IDT */
#endif
-#ifdef CONFIG_X86_CYCLONE
+#ifdef CONFIG_X86_SUMMIT
FIX_CYCLONE_TIMER, /*cyclone timer register*/
#endif
#ifdef CONFIG_HIGHMEM
diff -Nru a/include/asm-i386/mach-summit/mach_mpparse.h b/include/asm-i386/mach-summit/mach_mpparse.h
--- a/include/asm-i386/mach-summit/mach_mpparse.h Tue Jan 21 18:14:45 2003
+++ b/include/asm-i386/mach-summit/mach_mpparse.h Tue Jan 21 18:14:45 2003
@@ -1,6 +1,8 @@
#ifndef __ASM_MACH_MPPARSE_H
#define __ASM_MACH_MPPARSE_H
+extern int use_cyclone;
+
static inline void mpc_oem_bus_info(struct mpc_config_bus *m, char *name,
struct mpc_config_translation *translation)
{
@@ -17,14 +19,18 @@
{
if (!strncmp(oem, "IBM ENSW", 8) &&
(!strncmp(productid, "VIGIL SMP", 9)
- || !strncmp(productid, "RUTHLESS SMP", 12)))
+ || !strncmp(productid, "RUTHLESS SMP", 12))){
x86_summit = 1;
+ use_cyclone = 1; /*enable cyclone-timer*/
+ }
}
/* Hook from generic ACPI tables.c */
static inline void acpi_madt_oem_check(char *oem_id, char *oem_table_id)
{
- if (!strncmp(oem_id, "IBM", 3) && !strncmp(oem_table_id, "SERVIGIL", 8))
+ if (!strncmp(oem_id, "IBM", 3) && !strncmp(oem_table_id, "SERVIGIL", 8)){
x86_summit = 1;
+ use_cyclone = 1; /*enable cyclone-timer*/
+ }
}
#endif /* __ASM_MACH_MPPARSE_H */