2015-06-27 13:22:58

by Gabriele Mazzotta

[permalink] [raw]
Subject: [PATCH] hwmon: (dell-smm-hwon) Use a valid name attribute

As per Documentation/hwmon/sysfs-interface, hwmon name attributes must
not include '-', so replace 'dell-smm' with 'dell_smm'.

Fixes: 039ae58503f3 ("hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k")
Signed-off-by: Gabriele Mazzotta <[email protected]>
---
drivers/hwmon/dell-smm-hwmon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
index 2a80882..37c16af 100644
--- a/drivers/hwmon/dell-smm-hwmon.c
+++ b/drivers/hwmon/dell-smm-hwmon.c
@@ -777,7 +777,7 @@ static int __init i8k_init_hwmon(void)
if (err >= 0)
i8k_hwmon_flags |= I8K_HWMON_HAVE_FAN2;

- i8k_hwmon_dev = hwmon_device_register_with_groups(NULL, "dell-smm",
+ i8k_hwmon_dev = hwmon_device_register_with_groups(NULL, "dell_smm",
NULL, i8k_groups);
if (IS_ERR(i8k_hwmon_dev)) {
err = PTR_ERR(i8k_hwmon_dev);
--
2.1.4


2015-06-27 14:39:30

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH] hwmon: (dell-smm-hwon) Use a valid name attribute

On 06/27/2015 06:22 AM, Gabriele Mazzotta wrote:
> As per Documentation/hwmon/sysfs-interface, hwmon name attributes must
> not include '-', so replace 'dell-smm' with 'dell_smm'.
>
> Fixes: 039ae58503f3 ("hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k")
> Signed-off-by: Gabriele Mazzotta <[email protected]>

Applied.

Pali, would be great if you can send me an Acked-by: before I send
the pull request to Linus.

Thanks,
Guenter

2015-06-27 16:21:13

by Pali Rohár

[permalink] [raw]
Subject: Re: [PATCH] hwmon: (dell-smm-hwon) Use a valid name attribute

On Saturday 27 June 2015 16:39:09 Guenter Roeck wrote:
> On 06/27/2015 06:22 AM, Gabriele Mazzotta wrote:
> > As per Documentation/hwmon/sysfs-interface, hwmon name attributes
> > must not include '-', so replace 'dell-smm' with 'dell_smm'.
> >
> > Fixes: 039ae58503f3 ("hwmon: Allow to compile dell-smm-hwmon driver
> > without /proc/i8k") Signed-off-by: Gabriele Mazzotta
> > <[email protected]>
>
> Applied.
>
> Pali, would be great if you can send me an Acked-by: before I send
> the pull request to Linus.
>
> Thanks,
> Guenter

It's ok,

Acked-by: Pali Rohár <[email protected]>

--
Pali Rohár
[email protected]


Attachments:
signature.asc (198.00 B)
This is a digitally signed message part.