2003-02-12 06:19:16

by Robert Love

[permalink] [raw]
Subject: [patch] used but uninitialized variable in ac97_codec

As far as I can tell, nothing initializes `err' prior to the
snd_printk() that uses it. It is used later on, however.

So just do not print it out here.

Patch is against 2.5.60.

Robert Love

sound/pci/ac97/ac97_codec.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)


diff -urN linux-2.5.60/sound/pci/ac97/ac97_codec.c linux/sound/pci/ac97/ac97_codec.c
--- linux-2.5.60/sound/pci/ac97/ac97_codec.c 2003-02-10 13:38:19.000000000 -0500
+++ linux/sound/pci/ac97/ac97_codec.c 2003-02-12 00:46:51.000000000 -0500
@@ -1887,7 +1887,7 @@
udelay(50);
if (ac97_reset_wait(ac97, HZ/2, 0) < 0 &&
ac97_reset_wait(ac97, HZ/2, 1) < 0) {
- snd_printk("AC'97 %d:%d does not respond - RESET [REC_GAIN = 0x%x]\n", ac97->num, ac97->addr, err);
+ snd_printk("AC'97 %d:%d does not respond - RESET\n", ac97->num, ac97->addr);
snd_ac97_free(ac97);
return -ENXIO;
}