2015-08-10 09:16:05

by yalin wang

Subject: [PATCH] isdn:remove reverse_bits(), use revbit8()

This change isdn driver, remove reverse_bits() function,
use the generic revbit8() function instead.

Signed-off-by: yalin wang <[email protected]>
---
drivers/isdn/mISDN/dsp_audio.c | 22 +++++-----------------
1 file changed, 5 insertions(+), 17 deletions(-)

diff --git a/drivers/isdn/mISDN/dsp_audio.c b/drivers/isdn/mISDN/dsp_audio.c
index 0602295..bbef98e 100644
--- a/drivers/isdn/mISDN/dsp_audio.c
+++ b/drivers/isdn/mISDN/dsp_audio.c
@@ -13,6 +13,7 @@
#include <linux/mISDNif.h>
#include <linux/mISDNdsp.h>
#include <linux/export.h>
+#include <linux/bitrev.h>
#include "core.h"
#include "dsp.h"

@@ -137,27 +138,14 @@ static unsigned char linear2ulaw(short sample)
return ulawbyte;
}

-static int reverse_bits(int i)
-{
- int z, j;
- z = 0;
-
- for (j = 0; j < 8; j++) {
- if ((i & (1 << j)) != 0)
- z |= 1 << (7 - j);
- }
- return z;
-}
-
-
void dsp_audio_generate_law_tables(void)
{
int i;
for (i = 0; i < 256; i++)
- dsp_audio_alaw_to_s32[i] = alaw2linear(reverse_bits(i));
+ dsp_audio_alaw_to_s32[i] = alaw2linear(bitrev8((u8)i));

for (i = 0; i < 256; i++)
- dsp_audio_ulaw_to_s32[i] = ulaw2linear(reverse_bits(i));
+ dsp_audio_ulaw_to_s32[i] = ulaw2linear(bitrev8((u8)i));

for (i = 0; i < 256; i++) {
dsp_audio_alaw_to_ulaw[i] =
@@ -176,13 +164,13 @@ dsp_audio_generate_s2law_table(void)
/* generating ulaw-table */
for (i = -32768; i < 32768; i++) {
dsp_audio_s16_to_law[i & 0xffff] =
- reverse_bits(linear2ulaw(i));
+ bitrev8(linear2ulaw(i));
}
} else {
/* generating alaw-table */
for (i = -32768; i < 32768; i++) {
dsp_audio_s16_to_law[i & 0xffff] =
- reverse_bits(linear2alaw(i));
+ bitrev8(linear2alaw(i));
}
}
}
--
1.9.1

2015-08-10 21:30:17

by David Miller

Subject: Re: [PATCH] isdn:remove reverse_bits(), use revbit8()

From: yalin wang <[email protected]>
Date: Mon, 10 Aug 2015 17:15:57 +0800

> This change isdn driver, remove reverse_bits() function,
> use the generic revbit8() function instead.
>
> Signed-off-by: yalin wang <[email protected]>

Applied, however please format your Subject lines better in the
future.

There should be a space after the subsystem specifier and the ':'
character. So "isdn: "

Then you should capitalize the description in the Subject line
because it is very much like an English sentence.

2015-08-11 01:38:32

by yalin wang

Subject: Re: [PATCH] isdn:remove reverse_bits(), use revbit8()

> On Aug 11, 2015, at 05:30, David Miller <[email protected]> wrote:
>
> From: yalin wang <[email protected]>
> Date: Mon, 10 Aug 2015 17:15:57 +0800
>
>> This change isdn driver, remove reverse_bits() function,
>> use the generic revbit8() function instead.
>>
>> Signed-off-by: yalin wang <[email protected]>
>
> Applied, however please format your Subject lines better in the
> future.
>
> There should be a space after the subsystem specifier and the ':'
> character. So "isdn: "
>
> Then you should capitalize the description in the Subject line
> because it is very much like an English sentence.
i see,
Thanks for your kindly remind !