2015-08-21 03:40:35

by Leo Yan

[permalink] [raw]
Subject: [PATCH] arm64: enable generic idle loop

Enable generic idle loop for ARM64, so can support for hlt/nohlt
command line options to override default idle loop behavior.

Signed-off-by: Leo Yan <[email protected]>
---
arch/arm64/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index 0f6edb1..c404e74 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -31,6 +31,7 @@ config ARM64
select GENERIC_CLOCKEVENTS_BROADCAST if SMP
select GENERIC_CPU_AUTOPROBE
select GENERIC_EARLY_IOREMAP
+ select GENERIC_IDLE_POLL_SETUP
select GENERIC_IRQ_PROBE
select GENERIC_IRQ_SHOW
select GENERIC_IRQ_SHOW_LEVEL
--
1.9.1


2015-08-21 09:00:49

by Catalin Marinas

[permalink] [raw]
Subject: Re: [PATCH] arm64: enable generic idle loop

On Fri, Aug 21, 2015 at 11:40:22AM +0800, Leo Yan wrote:
> Enable generic idle loop for ARM64, so can support for hlt/nohlt
> command line options to override default idle loop behavior.

Just curious, what do you need this for?

--
Catalin

2015-08-21 09:14:54

by Leo Yan

[permalink] [raw]
Subject: Re: [PATCH] arm64: enable generic idle loop

On Fri, Aug 21, 2015 at 10:00:43AM +0100, Catalin Marinas wrote:
> On Fri, Aug 21, 2015 at 11:40:22AM +0800, Leo Yan wrote:
> > Enable generic idle loop for ARM64, so can support for hlt/nohlt
> > command line options to override default idle loop behavior.
>
> Just curious, what do you need this for?

With this config, usually we can add "nohlt" in command line to force
the cpu will never be powered off; so can quickly narrow down if some
issues are related with cpuidle or not.

And if CPU is powered off, then its debug logic also will be powered off.
So we can simply use this method to let debugger always hot connect with
the target CPU.

Thanks,
Leo Yan

2015-08-21 15:54:30

by Catalin Marinas

[permalink] [raw]
Subject: Re: [PATCH] arm64: enable generic idle loop

On Fri, Aug 21, 2015 at 05:14:46PM +0800, Leo Yan wrote:
> On Fri, Aug 21, 2015 at 10:00:43AM +0100, Catalin Marinas wrote:
> > On Fri, Aug 21, 2015 at 11:40:22AM +0800, Leo Yan wrote:
> > > Enable generic idle loop for ARM64, so can support for hlt/nohlt
> > > command line options to override default idle loop behavior.
> >
> > Just curious, what do you need this for?
>
> With this config, usually we can add "nohlt" in command line to force
> the cpu will never be powered off; so can quickly narrow down if some
> issues are related with cpuidle or not.
>
> And if CPU is powered off, then its debug logic also will be powered off.
> So we can simply use this method to let debugger always hot connect with
> the target CPU.

OK.

Acked-by: Catalin Marinas <[email protected]>