2015-08-25 08:50:47

by Valentin Rothberg

[permalink] [raw]
Subject: [PATCH] drivers/nfc/s3fwrn5/Makefile: remove superfluous cflags

NFC_DEBUG is not defined in Kconfig and since DEBUG is not used
anywhere in this directory, we can safely remove this line.

Signed-off-by: Valentin Rothberg <[email protected]>
---
I detected the issue with scripts/checkkconfigsymbols.py

drivers/nfc/s3fwrn5/Makefile | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/nfc/s3fwrn5/Makefile b/drivers/nfc/s3fwrn5/Makefile
index 3381c34faf62..ddfa7be7dd05 100644
--- a/drivers/nfc/s3fwrn5/Makefile
+++ b/drivers/nfc/s3fwrn5/Makefile
@@ -7,5 +7,3 @@ s3fwrn5_i2c-objs = i2c.o

obj-$(CONFIG_NFC_S3FWRN5) += s3fwrn5.o
obj-$(CONFIG_NFC_S3FWRN5_I2C) += s3fwrn5_i2c.o
-
-ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG
--
1.9.1


2015-08-31 07:54:28

by Robert Baldyga

[permalink] [raw]
Subject: Re: [PATCH] drivers/nfc/s3fwrn5/Makefile: remove superfluous cflags

On 08/25/2015 10:50 AM, Valentin Rothberg wrote:
> NFC_DEBUG is not defined in Kconfig and since DEBUG is not used
> anywhere in this directory, we can safely remove this line.
>
> Signed-off-by: Valentin Rothberg <[email protected]>

Acked-by: Robert Baldyga <[email protected]>

Thanks,
Robert Baldyga

> ---
> I detected the issue with scripts/checkkconfigsymbols.py
>
> drivers/nfc/s3fwrn5/Makefile | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/nfc/s3fwrn5/Makefile b/drivers/nfc/s3fwrn5/Makefile
> index 3381c34faf62..ddfa7be7dd05 100644
> --- a/drivers/nfc/s3fwrn5/Makefile
> +++ b/drivers/nfc/s3fwrn5/Makefile
> @@ -7,5 +7,3 @@ s3fwrn5_i2c-objs = i2c.o
>
> obj-$(CONFIG_NFC_S3FWRN5) += s3fwrn5.o
> obj-$(CONFIG_NFC_S3FWRN5_I2C) += s3fwrn5_i2c.o
> -
> -ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG
>

2015-08-31 08:02:47

by Robert Baldyga

[permalink] [raw]
Subject: Re: [PATCH] drivers/nfc/s3fwrn5/Makefile: remove superfluous cflags

[ +cc Samuel Ortiz and <[email protected]> ]

Hi Samuel,

Could you please apply this patch?

Thanks,
Robert

On 08/31/2015 09:54 AM, Robert Baldyga wrote:
> On 08/25/2015 10:50 AM, Valentin Rothberg wrote:
>> NFC_DEBUG is not defined in Kconfig and since DEBUG is not used
>> anywhere in this directory, we can safely remove this line.
>>
>> Signed-off-by: Valentin Rothberg <[email protected]>
>
> Acked-by: Robert Baldyga <[email protected]>
>
> Thanks,
> Robert Baldyga
>
>> ---
>> I detected the issue with scripts/checkkconfigsymbols.py
>>
>> drivers/nfc/s3fwrn5/Makefile | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/nfc/s3fwrn5/Makefile b/drivers/nfc/s3fwrn5/Makefile
>> index 3381c34faf62..ddfa7be7dd05 100644
>> --- a/drivers/nfc/s3fwrn5/Makefile
>> +++ b/drivers/nfc/s3fwrn5/Makefile
>> @@ -7,5 +7,3 @@ s3fwrn5_i2c-objs = i2c.o
>>
>> obj-$(CONFIG_NFC_S3FWRN5) += s3fwrn5.o
>> obj-$(CONFIG_NFC_S3FWRN5_I2C) += s3fwrn5_i2c.o
>> -
>> -ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG
>>
>