2015-11-22 12:48:48

by Saurabh Sengar

Subject: [PATCH] IB/mlx5: fix null dereference

removing null dereference

Signed-off-by: Saurabh Sengar <[email protected]>
---
is there any better way to fix it ?
as if there is no 'x' there is no way we can access 'x->lock'

drivers/infiniband/hw/mlx5/qp.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
index 307bdbc..613a853 100644
--- a/drivers/infiniband/hw/mlx5/qp.c
+++ b/drivers/infiniband/hw/mlx5/qp.c
@@ -1064,13 +1064,10 @@ static void mlx5_ib_lock_cqs(struct mlx5_ib_cq *send_cq, struct mlx5_ib_cq *recv
}
} else {
spin_lock_irq(&send_cq->lock);
- __acquire(&recv_cq->lock);
}
} else if (recv_cq) {
spin_lock_irq(&recv_cq->lock);
- __acquire(&send_cq->lock);
} else {
- __acquire(&send_cq->lock);
__acquire(&recv_cq->lock);
}
}
@@ -1091,15 +1088,12 @@ static void mlx5_ib_unlock_cqs(struct mlx5_ib_cq *send_cq, struct mlx5_ib_cq *re
spin_unlock_irq(&recv_cq->lock);
}
} else {
- __release(&recv_cq->lock);
spin_unlock_irq(&send_cq->lock);
}
} else if (recv_cq) {
- __release(&send_cq->lock);
spin_unlock_irq(&recv_cq->lock);
} else {
__release(&recv_cq->lock);
- __release(&send_cq->lock);
}
}

--
1.9.1

2015-11-22 17:41:40

by Christoph Hellwig

Subject: Re: [PATCH] IB/mlx5: fix null dereference

On Sun, Nov 22, 2015 at 06:18:37PM +0530, Saurabh Sengar wrote:
> removing null dereference

How so? These are just sparse annotations, so I can't see how we'll
actually derference them. That beeing said they certainly are
incorrect..