2015-12-04 14:20:20

by Corentin Labbe

Subject: [PATCH] rtc: Replace simple_strtoul by kstrtoul

The simple_strtoul function is obsolete.
This patch replace it by kstrtoul.

Signed-off-by: LABBE Corentin <[email protected]>
---
drivers/rtc/rtc-sysfs.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-sysfs.c b/drivers/rtc/rtc-sysfs.c
index 7273855..a023f63 100644
--- a/drivers/rtc/rtc-sysfs.c
+++ b/drivers/rtc/rtc-sysfs.c
@@ -91,7 +91,12 @@ max_user_freq_store(struct device *dev, struct device_attribute *attr,
const char *buf, size_t n)
{
struct rtc_device *rtc = to_rtc_device(dev);
- unsigned long val = simple_strtoul(buf, NULL, 0);
+ unsigned long val;
+ int err;
+
+ err = kstrtoul(buf, 0, &val);
+ if (err)
+ return err;

if (val >= 4096 || val == 0)
return -EINVAL;
--
2.4.10

2015-12-13 13:53:23

by Alexandre Belloni

Subject: Re: [PATCH] rtc: Replace simple_strtoul by kstrtoul

Hi,

On 04/12/2015 at 15:19:39 +0100, LABBE Corentin wrote :
> The simple_strtoul function is obsolete.
> This patch replace it by kstrtoul.
>
> Signed-off-by: LABBE Corentin <[email protected]>
> ---
> drivers/rtc/rtc-sysfs.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-sysfs.c b/drivers/rtc/rtc-sysfs.c
> index 7273855..a023f63 100644
> --- a/drivers/rtc/rtc-sysfs.c
> +++ b/drivers/rtc/rtc-sysfs.c
> @@ -91,7 +91,12 @@ max_user_freq_store(struct device *dev, struct device_attribute *attr,
> const char *buf, size_t n)
> {
> struct rtc_device *rtc = to_rtc_device(dev);
> - unsigned long val = simple_strtoul(buf, NULL, 0);
> + unsigned long val;
> + int err;
> +
> + err = kstrtoul(buf, 0, &val);
> + if (err)
> + return err;
>

There are other uses in the same file, you might as well change them.


--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com