2003-03-12 08:53:28

by Andrey Panin

[permalink] [raw]
Subject: [PATCH] consolidate crc16 calculations (ppp part)

Hi,

attached patch (2.5.64) converts aysnc ppp driver to use common crc16 module.

Please consider applying.

Best regards.

--
Andrey Panin | Embedded systems software developer
[email protected] | PGP key: wwwkeys.pgp.net

Attachments:
(No filename) (226.00 B)
 patch-crc16-ppp (3.78 kB)
 Download all attachments

2003-03-12 10:11:48

by Paul Mackerras

[permalink] [raw]
Subject: Re: [PATCH] consolidate crc16 calculations (ppp part)

Andrey Panin writes:

> attached patch (2.5.64) converts aysnc ppp driver to use common crc16 module.
>
> Please consider applying.

The only hesitation I have is that the Makefile system for the crc
functions seems to be broken - if you request to have the crc
functions built-in, but nothing built-in uses them, then the linker
doesn't included them.

Other than that I would say go for it.

Paul.