2016-03-11 14:16:20

by Peter Ujfalusi

Subject: [PATCH] clk: ti: dra7-atl-clock: Fix of_node reference counting

of_find_node_by_name() will call of_node_put() on the node so we need to
get it first to avoid warnings.
The cfg_node needs to be put after we have finished processing the
properties.

Signed-off-by: Peter Ujfalusi <[email protected]>
---
drivers/clk/ti/clk-dra7-atl.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/clk/ti/clk-dra7-atl.c b/drivers/clk/ti/clk-dra7-atl.c
index 2e14dfb588f4..c77333230bdf 100644
--- a/drivers/clk/ti/clk-dra7-atl.c
+++ b/drivers/clk/ti/clk-dra7-atl.c
@@ -265,6 +265,7 @@ static int of_dra7_atl_clk_probe(struct platform_device *pdev)

/* Get configuration for the ATL instances */
snprintf(prop, sizeof(prop), "atl%u", i);
+ of_node_get(node);
cfg_node = of_find_node_by_name(node, prop);
if (cfg_node) {
ret = of_property_read_u32(cfg_node, "bws",
@@ -278,6 +279,7 @@ static int of_dra7_atl_clk_probe(struct platform_device *pdev)
atl_write(cinfo, DRA7_ATL_AWSMUX_REG(i),
cdesc->aws);
}
+ of_node_put(cfg_node);
}

cdesc->probed = true;
--
2.7.2

2016-03-11 20:19:34

by Nishanth Menon

Subject: Re: [PATCH] clk: ti: dra7-atl-clock: Fix of_node reference counting

On 03/11/2016 08:13 AM, Peter Ujfalusi wrote:
> of_find_node_by_name() will call of_node_put() on the node so we need to
> get it first to avoid warnings.
> The cfg_node needs to be put after we have finished processing the
> properties.
>
> Signed-off-by: Peter Ujfalusi <[email protected]>
> ---
> drivers/clk/ti/clk-dra7-atl.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/clk/ti/clk-dra7-atl.c b/drivers/clk/ti/clk-dra7-atl.c
> index 2e14dfb588f4..c77333230bdf 100644
> --- a/drivers/clk/ti/clk-dra7-atl.c
> +++ b/drivers/clk/ti/clk-dra7-atl.c
> @@ -265,6 +265,7 @@ static int of_dra7_atl_clk_probe(struct platform_device *pdev)
>
> /* Get configuration for the ATL instances */
> snprintf(prop, sizeof(prop), "atl%u", i);
> + of_node_get(node);
> cfg_node = of_find_node_by_name(node, prop);
> if (cfg_node) {
> ret = of_property_read_u32(cfg_node, "bws",
> @@ -278,6 +279,7 @@ static int of_dra7_atl_clk_probe(struct platform_device *pdev)
> atl_write(cinfo, DRA7_ATL_AWSMUX_REG(i),
> cdesc->aws);
> }
> + of_node_put(cfg_node);
> }
>
> cdesc->probed = true;
>

Tested-by: Nishanth Menon <[email protected]>

--
Regards,
Nishanth Menon

2016-04-16 00:47:45

by Stephen Boyd

Subject: Re: [PATCH] clk: ti: dra7-atl-clock: Fix of_node reference counting

On 03/11, Peter Ujfalusi wrote:
> of_find_node_by_name() will call of_node_put() on the node so we need to
> get it first to avoid warnings.
> The cfg_node needs to be put after we have finished processing the
> properties.
>
> Signed-off-by: Peter Ujfalusi <[email protected]>
> ---

Applied to clk-next

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project