2016-03-14 02:28:05

by Joe Perches

Subject: [PATCH] kdb: Replace strncasecmp with strcasecmp

Remove the unnecessary last sizeof("foo") argument to strncasecmp using
strcasecmp without that sizeof as it iss equivalent, simpler and smaller.

Signed-off-by: Joe Perches <[email protected]>
---
kernel/debug/kdb/kdb_bp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/debug/kdb/kdb_bp.c b/kernel/debug/kdb/kdb_bp.c
index 90ff129..4714b33 100644
--- a/kernel/debug/kdb/kdb_bp.c
+++ b/kernel/debug/kdb/kdb_bp.c
@@ -52,11 +52,11 @@ static int kdb_parsebp(int argc, const char **argv, int *nextargp, kdb_bp_t *bp)

bp->bph_length = 1;
if ((argc + 1) != nextarg) {
- if (strncasecmp(argv[nextarg], "datar", sizeof("datar")) == 0)
+ if (strcasecmp(argv[nextarg], "datar") == 0)
bp->bp_type = BP_ACCESS_WATCHPOINT;
- else if (strncasecmp(argv[nextarg], "dataw", sizeof("dataw")) == 0)
+ else if (strcasecmp(argv[nextarg], "dataw") == 0)
bp->bp_type = BP_WRITE_WATCHPOINT;
- else if (strncasecmp(argv[nextarg], "inst", sizeof("inst")) == 0)
+ else if (strcasecmp(argv[nextarg], "inst") == 0)
bp->bp_type = BP_HARDWARE_BREAKPOINT;
else
return KDB_ARGCOUNT;
--
2.6.3.368.gf34be46

2016-03-14 13:53:04

by Daniel Thompson

Subject: Re: [PATCH] kdb: Replace strncasecmp with strcasecmp

On 14/03/16 02:27, Joe Perches wrote:
> Remove the unnecessary last sizeof("foo") argument to strncasecmp using
> strcasecmp without that sizeof as it iss equivalent, simpler and smaller.
>
> Signed-off-by: Joe Perches <[email protected]>

Reviewed-by: Daniel Thompson <[email protected]>


> ---
> kernel/debug/kdb/kdb_bp.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/debug/kdb/kdb_bp.c b/kernel/debug/kdb/kdb_bp.c
> index 90ff129..4714b33 100644
> --- a/kernel/debug/kdb/kdb_bp.c
> +++ b/kernel/debug/kdb/kdb_bp.c
> @@ -52,11 +52,11 @@ static int kdb_parsebp(int argc, const char **argv, int *nextargp, kdb_bp_t *bp)
>
> bp->bph_length = 1;
> if ((argc + 1) != nextarg) {
> - if (strncasecmp(argv[nextarg], "datar", sizeof("datar")) == 0)
> + if (strcasecmp(argv[nextarg], "datar") == 0)
> bp->bp_type = BP_ACCESS_WATCHPOINT;
> - else if (strncasecmp(argv[nextarg], "dataw", sizeof("dataw")) == 0)
> + else if (strcasecmp(argv[nextarg], "dataw") == 0)
> bp->bp_type = BP_WRITE_WATCHPOINT;
> - else if (strncasecmp(argv[nextarg], "inst", sizeof("inst")) == 0)
> + else if (strcasecmp(argv[nextarg], "inst") == 0)
> bp->bp_type = BP_HARDWARE_BREAKPOINT;
> else
> return KDB_ARGCOUNT;
>