2016-04-15 14:46:41

by Dan Carpenter

Subject: [patch] intel_telemetry_pltdrv: silence an unintialized variable warning

Presumably "pss_period" and "ioss_period" can't both be zero, but this
function is never called so we can't infer that using static analysis
alone.

Let's silence the warning by setting "ret" to zero.

Signed-off-by: Dan Carpenter <[email protected]>

diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c b/drivers/platform/x86/intel_telemetry_pltdrv.c
index 397119f..781bd10 100644
--- a/drivers/platform/x86/intel_telemetry_pltdrv.c
+++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
@@ -659,7 +659,7 @@ static int telemetry_plt_update_events(struct telemetry_evtconfig pss_evtconfig,
static int telemetry_plt_set_sampling_period(u8 pss_period, u8 ioss_period)
{
u32 telem_ctrl = 0;
- int ret;
+ int ret = 0;

mutex_lock(&(telm_conf->telem_lock));
if (ioss_period) {

2016-04-18 04:29:08

by Souvik Kumar Chakravarty

Subject: RE: [patch] intel_telemetry_pltdrv: silence an unintialized variable warning

Looks good...thanks Dan.

> -----Original Message-----
> From: Dan Carpenter [mailto:[email protected]]
> Sent: Friday, April 15, 2016 8:16 PM
> To: Chakravarty, Souvik K <[email protected]>
> Cc: Darren Hart <[email protected]>; platform-driver-
> [email protected]; [email protected]; kernel-
> [email protected]
> Subject: [patch] intel_telemetry_pltdrv: silence an unintialized variable
> warning
>
> Presumably "pss_period" and "ioss_period" can't both be zero, but this
> function is never called so we can't infer that using static analysis alone.
>
> Let's silence the warning by setting "ret" to zero.
>
> Signed-off-by: Dan Carpenter <[email protected]>
>
> diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c
> b/drivers/platform/x86/intel_telemetry_pltdrv.c
> index 397119f..781bd10 100644
> --- a/drivers/platform/x86/intel_telemetry_pltdrv.c
> +++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
> @@ -659,7 +659,7 @@ static int telemetry_plt_update_events(struct
> telemetry_evtconfig pss_evtconfig, static int
> telemetry_plt_set_sampling_period(u8 pss_period, u8 ioss_period) {
> u32 telem_ctrl = 0;
> - int ret;
> + int ret = 0;
>
> mutex_lock(&(telm_conf->telem_lock));
> if (ioss_period) {