2016-04-26 17:16:04

by Yang Shi

Subject: [PATCH] powerpc/4xx: make sam440ep_setup_rtc init

sam440ep_setup_rtc is just called by machine_device_initcall, and it calls
i2c_register_board_info which is init too, so the lack of __init may cause
mismatch warning when linking kernel.

Signed-off-by: Yang Shi <[email protected]>
---
arch/powerpc/platforms/44x/sam440ep.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/44x/sam440ep.c b/arch/powerpc/platforms/44x/sam440ep.c
index 3ee4a03..fbecfc1 100644
--- a/arch/powerpc/platforms/44x/sam440ep.c
+++ b/arch/powerpc/platforms/44x/sam440ep.c
@@ -72,7 +72,7 @@ static struct i2c_board_info sam440ep_rtc_info = {
.irq = -1,
};

-static int sam440ep_setup_rtc(void)
+static int __init sam440ep_setup_rtc(void)
{
return i2c_register_board_info(0, &sam440ep_rtc_info, 1);
}
--
2.0.2

2017-04-03 10:13:22

by Michael Ellerman

Subject: Re: powerpc/4xx: make sam440ep_setup_rtc init

On Tue, 2016-04-26 at 16:49:38 UTC, yshi wrote:
> sam440ep_setup_rtc is just called by machine_device_initcall, and it calls
> i2c_register_board_info which is init too, so the lack of __init may cause
> mismatch warning when linking kernel.
>
> Signed-off-by: Yang Shi <[email protected]>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/adec9a2e7ca3b4193818f9a7b39563

cheers