2016-11-07 19:06:41

by Nicholas Mc Guire

Subject: [PATCH] usb: dwc2: gadget: simplify list handling

The current code is effectively equivalent to list_first_entry_or_null()
so simply switch and simplify the code.

Fixes: 9c39ddc60ee9 ("USB: s3c-hsotg: Fix stall condition processing")
Signed-off-by: Nicholas Mc Guire <[email protected]>
---
Found by simple coccinelle scanner

Compile tested with: x86_64_defconfig + CONFIG_USB_DWC2=m,
CONFIG_USB_DWC2_PERIPHERAL=y

Patch is against 4.9.0-rc2 (localversion-next is next-20161028)

drivers/usb/dwc2/gadget.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index 24fbebc..9ac8ca0 100644
--- a/drivers/usb/dwc2/gadget.c
+++ b/drivers/usb/dwc2/gadget.c
@@ -1099,10 +1099,8 @@ static int dwc2_hsotg_process_req_status(struct dwc2_hsotg *hsotg,
*/
static struct dwc2_hsotg_req *get_ep_head(struct dwc2_hsotg_ep *hs_ep)
{
- if (list_empty(&hs_ep->queue))
- return NULL;
-
- return list_first_entry(&hs_ep->queue, struct dwc2_hsotg_req, queue);
+ return list_first_entry_or_null(&hs_ep->queue,
+ struct dwc2_hsotg_req, queue);
}

/**
--
1.7.10.4

2016-11-07 19:17:03

by John Youn

Subject: Re: [PATCH] usb: dwc2: gadget: simplify list handling

On 11/7/2016 11:06 AM, Nicholas Mc Guire wrote:
> The current code is effectively equivalent to list_first_entry_or_null()
> so simply switch and simplify the code.
>
> Fixes: 9c39ddc60ee9 ("USB: s3c-hsotg: Fix stall condition processing")
> Signed-off-by: Nicholas Mc Guire <[email protected]>
> ---
> Found by simple coccinelle scanner
>
> Compile tested with: x86_64_defconfig + CONFIG_USB_DWC2=m,
> CONFIG_USB_DWC2_PERIPHERAL=y
>
> Patch is against 4.9.0-rc2 (localversion-next is next-20161028)
>
> drivers/usb/dwc2/gadget.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
> index 24fbebc..9ac8ca0 100644
> --- a/drivers/usb/dwc2/gadget.c
> +++ b/drivers/usb/dwc2/gadget.c
> @@ -1099,10 +1099,8 @@ static int dwc2_hsotg_process_req_status(struct dwc2_hsotg *hsotg,
> */
> static struct dwc2_hsotg_req *get_ep_head(struct dwc2_hsotg_ep *hs_ep)
> {
> - if (list_empty(&hs_ep->queue))
> - return NULL;
> -
> - return list_first_entry(&hs_ep->queue, struct dwc2_hsotg_req, queue);
> + return list_first_entry_or_null(&hs_ep->queue,
> + struct dwc2_hsotg_req, queue);
> }
>
> /**
>


Hi,

The same is already queued in Felipe's testing/next.

Regards,
John