2003-06-05 18:13:15

by Stephen Hemminger

Subject: [PATCH] typo in new class_device_release

There is a typo in the current 2.5.70 bk version of class_device_release that
was not there in my original patch. By confusing the class and the class_device,
the release function oops. cd->release is always the function itself (class_device_release),
cls->release is the one setup for the class (net_class in my case).

diff -Nru a/drivers/base/class.c b/drivers/base/class.c
--- a/drivers/base/class.c Thu Jun 5 11:21:42 2003
+++ b/drivers/base/class.c Thu Jun 5 11:21:42 2003
@@ -191,7 +191,7 @@
pr_debug("device class '%s': release.\n",cd->class_id);

if (cls->release)
- cd->release(cd);
+ cls->release(cd);
}

static struct kobj_type ktype_class_device = {

2003-06-05 19:50:20

by Patrick Mochel

Subject: Re: [PATCH] typo in new class_device_release

On Thu, 5 Jun 2003, Stephen Hemminger wrote:

> There is a typo in the current 2.5.70 bk version of class_device_release that
> was not there in my original patch. By confusing the class and the class_device,
> the release function oops. cd->release is always the function itself (class_device_release),
> cls->release is the one setup for the class (net_class in my case).

Bah, sloppy fixup..

Thanks,


-pat