The driver may sleep under a spin lock, and the function call path is:
ubifs_change_lp (acquire the lock by spin_lock)
change_category
ubifs_remove_from_cat
remove_from_lpt_heap
dbg_check_heap
ubifs_lpt_lookup
ubifs_get_pnode
read_pnode
kzalloc(GFP_NOFS) --> may sleep
To fix it, "GFP_NOFS" is replaced with "GFP_ATOMIC".
Signed-off-by: Jia-Ju Bai <[email protected]>
---
fs/ubifs/lpt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ubifs/lpt.c b/fs/ubifs/lpt.c
index 9a51710..fabe2fd 100644
--- a/fs/ubifs/lpt.c
+++ b/fs/ubifs/lpt.c
@@ -1268,7 +1268,7 @@ static int read_pnode(struct ubifs_info *c, struct ubifs_nnode *parent, int iip)
branch = &parent->nbranch[iip];
lnum = branch->lnum;
offs = branch->offs;
- pnode = kzalloc(sizeof(struct ubifs_pnode), GFP_NOFS);
+ pnode = kzalloc(sizeof(struct ubifs_pnode), GFP_ATOMIC);
if (!pnode)
return -ENOMEM;
--
1.7.9.5