2017-06-09 05:15:49

by Derek Robson

Subject: [PATCH] Drivers: unisys: visorhba - style fix

Fixed style of permissions to octal.
Found using checkpatch

Signed-off-by: Derek Robson <[email protected]>
---
drivers/staging/unisys/visorhba/visorhba_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c b/drivers/staging/unisys/visorhba/visorhba_main.c
index 2fd31c9762c6..a6e7a6bbc428 100644
--- a/drivers/staging/unisys/visorhba/visorhba_main.c
+++ b/drivers/staging/unisys/visorhba/visorhba_main.c
@@ -1090,7 +1090,7 @@ static int visorhba_probe(struct visor_device *dev)
goto err_scsi_remove_host;
}
devdata->debugfs_info =
- debugfs_create_file("info", S_IRUSR | S_IRGRP,
+ debugfs_create_file("info", 0440,
devdata->debugfs_dir, devdata,
&info_debugfs_fops);
if (!devdata->debugfs_info) {
--
2.13.0

2017-06-09 14:32:23

by Kershner, David A

Subject: RE: [PATCH] Drivers: unisys: visorhba - style fix

> -----Original Message-----
> From: Derek Robson [mailto:[email protected]]
> Sent: Friday, June 9, 2017 1:16 AM
> To: Kershner, David A <[email protected]>;
> [email protected]; Binder, David Anthony
> <[email protected]>; Sell, Timothy C <[email protected]>;
> Wadgaonkar, Sameer Laxmikant <[email protected]>;
> Thompson, Bryan E. <[email protected]>; [email protected]
> Cc: *S-Par-Maintainer <[email protected]>;
> [email protected]; [email protected]
> Subject: [PATCH] Drivers: unisys: visorhba - style fix
>
> Fixed style of permissions to octal.
> Found using checkpatch
>
> Signed-off-by: Derek Robson <[email protected]>

Acked-by: David Kershner <[email protected]>

> ---
> drivers/staging/unisys/visorhba/visorhba_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c
> b/drivers/staging/unisys/visorhba/visorhba_main.c
> index 2fd31c9762c6..a6e7a6bbc428 100644
> --- a/drivers/staging/unisys/visorhba/visorhba_main.c
> +++ b/drivers/staging/unisys/visorhba/visorhba_main.c
> @@ -1090,7 +1090,7 @@ static int visorhba_probe(struct visor_device *dev)
> goto err_scsi_remove_host;
> }
> devdata->debugfs_info =
> - debugfs_create_file("info", S_IRUSR | S_IRGRP,
> + debugfs_create_file("info", 0440,
> devdata->debugfs_dir, devdata,
> &info_debugfs_fops);
> if (!devdata->debugfs_info) {
> --
> 2.13.0

2017-06-10 11:27:52

by Dan Carpenter

Subject: Re: [PATCH] Drivers: unisys: visorhba - style fix

Drivers is never a valid subsystem. Do a `git log --oneline <file>` to
look at what other people are doing. The style varies by subsystem so
you should always run that command.

regards,
dan carpenter