2017-06-09 10:32:01

by Arnd Bergmann

Subject: [PATCH] drm: omapdrm: remove unused variable

Removing the default display name left a harmless warning:

fbdev/omap2/omapfb/dss/core.c: In function 'omap_dss_probe':
fbdev/omap2/omapfb/dss/core.c:196:30: error: unused variable 'pdata' [-Werror=unused-variable]

This removes the now-unused variable as well.

Fixes: 278cba7eaf54 ("drm: omapdrm: Remove unused default display name support")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/video/fbdev/omap2/omapfb/dss/core.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/video/fbdev/omap2/omapfb/dss/core.c b/drivers/video/fbdev/omap2/omapfb/dss/core.c
index eecf695c16f4..09e5bb013d28 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/core.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/core.c
@@ -193,7 +193,6 @@ static struct notifier_block omap_dss_pm_notif_block = {

static int __init omap_dss_probe(struct platform_device *pdev)
{
- struct omap_dss_board_info *pdata = pdev->dev.platform_data;
int r;

core.pdev = pdev;
--
2.9.0

2017-06-10 09:04:19

by Laurent Pinchart

Subject: Re: [PATCH] drm: omapdrm: remove unused variable

Hi Arnd,

Thank you for the patch.

On Friday 09 Jun 2017 12:31:03 Arnd Bergmann wrote:
> Removing the default display name left a harmless warning:
>
> fbdev/omap2/omapfb/dss/core.c: In function 'omap_dss_probe':
> fbdev/omap2/omapfb/dss/core.c:196:30: error: unused variable 'pdata'
> [-Werror=unused-variable]
>
> This removes the now-unused variable as well.
>
> Fixes: 278cba7eaf54 ("drm: omapdrm: Remove unused default display name
> support")
> Signed-off-by: Arnd Bergmann <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> drivers/video/fbdev/omap2/omapfb/dss/core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/omap2/omapfb/dss/core.c
> b/drivers/video/fbdev/omap2/omapfb/dss/core.c index
> eecf695c16f4..09e5bb013d28 100644
> --- a/drivers/video/fbdev/omap2/omapfb/dss/core.c
> +++ b/drivers/video/fbdev/omap2/omapfb/dss/core.c
> @@ -193,7 +193,6 @@ static struct notifier_block omap_dss_pm_notif_block = {
>
> static int __init omap_dss_probe(struct platform_device *pdev)
> {
> - struct omap_dss_board_info *pdata = pdev->dev.platform_data;
> int r;
>
> core.pdev = pdev;

--
Regards,

Laurent Pinchart