2017-06-14 21:35:26

by Dawid Kurek

Subject: [PATCH] drm: Remove duplicate forward declaration

Forward declarations in C are great but I'm pretty sure one is enough.

Signed-off-by: Dawid Kurek <[email protected]>
---
include/drm/drm_connector.h | 2 --
1 file changed, 2 deletions(-)

diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
index 4eeda12..930222c 100644
--- a/include/drm/drm_connector.h
+++ b/include/drm/drm_connector.h
@@ -29,8 +29,6 @@

#include <uapi/drm/drm_mode.h>

-struct drm_device;
-
struct drm_connector_helper_funcs;
struct drm_modeset_acquire_ctx;
struct drm_device;
--
2.10.0


---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus

2017-06-15 16:30:00

by Sean Paul

Subject: Re: [PATCH] drm: Remove duplicate forward declaration

On Wed, Jun 14, 2017 at 11:35:18PM +0200, Dawid Kurek wrote:
> Forward declarations in C are great but I'm pretty sure one is enough.

Applied to drm-misc-next

Thanks,

Sean

>
> Signed-off-by: Dawid Kurek <[email protected]>
> ---
> include/drm/drm_connector.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
> index 4eeda12..930222c 100644
> --- a/include/drm/drm_connector.h
> +++ b/include/drm/drm_connector.h
> @@ -29,8 +29,6 @@
>
> #include <uapi/drm/drm_mode.h>
>
> -struct drm_device;
> -
> struct drm_connector_helper_funcs;
> struct drm_modeset_acquire_ctx;
> struct drm_device;
> --
> 2.10.0
>
>
> ---
> This email has been checked for viruses by Avast antivirus software.
> https://www.avast.com/antivirus

--
Sean Paul, Software Engineer, Google / Chromium OS