2017-06-29 05:51:59

by Arvind Yadav

Subject: [PATCH] net: smc91x: constify dev_pm_ops structures.

dev_pm_ops are not supposed to change at runtime. All functions
working with dev_pm_ops provided by <linux/device.h> work with const
dev_pm_ops. So mark the non-const structs as const.

File size before:
text data bss dec hex filename
18709 401 0 19110 4aa6 drivers/net/ethernet/smsc/smc91x.o

File size After adding 'const':
text data bss dec hex filename
18901 201 0 19102 4a9e drivers/net/ethernet/smsc/smc91x.o

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/net/ethernet/smsc/smc91x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c
index 91e9bd7..83cf052 100644
--- a/drivers/net/ethernet/smsc/smc91x.c
+++ b/drivers/net/ethernet/smsc/smc91x.c
@@ -2488,7 +2488,7 @@ static int smc_drv_resume(struct device *dev)
return 0;
}

-static struct dev_pm_ops smc_drv_pm_ops = {
+static const struct dev_pm_ops smc_drv_pm_ops = {
.suspend = smc_drv_suspend,
.resume = smc_drv_resume,
};
--
1.9.1

2017-06-29 19:50:06

by David Miller

Subject: Re: [PATCH] net: smc91x: constify dev_pm_ops structures.

From: Arvind Yadav <[email protected]>
Date: Thu, 29 Jun 2017 11:21:00 +0530

> dev_pm_ops are not supposed to change at runtime. All functions
> working with dev_pm_ops provided by <linux/device.h> work with const
> dev_pm_ops. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 18709 401 0 19110 4aa6 drivers/net/ethernet/smsc/smc91x.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 18901 201 0 19102 4a9e drivers/net/ethernet/smsc/smc91x.o
>
> Signed-off-by: Arvind Yadav <[email protected]>

Applied.