2017-06-30 10:14:59

by Arvind Yadav

[permalink] [raw]
Subject: [PATCH] block: Constify attribute_group structures.

attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work with const
attribute_group. So mark the non-const structs as const.

File size before:
text data bss dec hex filename
5302 544 0 5846 16d6 block/partition-generic.o

File size After adding 'const':
text data bss dec hex filename
5342 480 0 5822 16be block/partition-generic.o

Signed-off-by: Arvind Yadav <[email protected]>
---
block/partition-generic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/partition-generic.c b/block/partition-generic.c
index ff07b91..47fa20d 100644
--- a/block/partition-generic.c
+++ b/block/partition-generic.c
@@ -196,7 +196,7 @@ static DEVICE_ATTR(discard_alignment, S_IRUGO, part_discard_alignment_show,
NULL
};

-static struct attribute_group part_attr_group = {
+static const struct attribute_group part_attr_group = {
.attrs = part_attrs,
};

--
1.9.1