2017-06-30 13:03:22

by Arvind Yadav

[permalink] [raw]
Subject: [PATCH] ACPI / DPTF: constify attribute_group structures.

attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work with const
attribute_group. So mark the non-const structs as const.

File size before:
text data bss dec hex filename
904 496 0 1400 578 drivers/acpi/dptf/dptf_power.o

File size After adding 'const':
text data bss dec hex filename
944 432 0 1376 560 drivers/acpi/dptf/dptf_power.o

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/acpi/dptf/dptf_power.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/dptf/dptf_power.c b/drivers/acpi/dptf/dptf_power.c
index 734642d..e1c2425 100644
--- a/drivers/acpi/dptf/dptf_power.c
+++ b/drivers/acpi/dptf/dptf_power.c
@@ -65,7 +65,7 @@
NULL
};

-static struct attribute_group dptf_power_attribute_group = {
+static const struct attribute_group dptf_power_attribute_group = {
.attrs = dptf_power_attrs,
.name = "dptf_power"
};
--
1.9.1