2017-07-05 10:57:20

by Arvind Yadav

[permalink] [raw]
Subject: [PATCH] input: elantech: constify attribute_group structures.

attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work with const
attribute_group. So mark the non-const structs as const.

File size before:
text data bss dec hex filename
16815 1424 0 18239 473f drivers/input/mouse/elantech.o

File size After adding 'const':
text data bss dec hex filename
16879 1360 0 18239 473f drivers/input/mouse/elantech.o

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/input/mouse/elantech.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
index e73d968..b6fd752 100644
--- a/drivers/input/mouse/elantech.c
+++ b/drivers/input/mouse/elantech.c
@@ -1375,7 +1375,7 @@ static ssize_t elantech_set_int_attr(struct psmouse *psmouse,
NULL
};

-static struct attribute_group elantech_attr_group = {
+static const struct attribute_group elantech_attr_group = {
.attrs = elantech_attrs,
};

--
1.9.1