LinuxLists.cc - [PATCH v2 00/10] Constify attribute

2017-07-11 07:33:20

Subject: [PATCH v2 00/10] Constify attribute_group structures

attribute_groups are not supposed to change at runtime. So mark the
non-const structs as const.

Arvind Yadav (10):
[PATCH v2 01/10] net: cdc_ncm: constify attribute_group structures.
[PATCH v2 02/10] net: can: at91_can: constify attribute_group structures.
[PATCH v2 03/10] net: can: janz-ican3: constify attribute_group structures.
[PATCH v2 04/10] wireless: ipw2200: constify attribute_group structures.
[PATCH v2 05/10] wireless: ipw2100: constify attribute_group structures.
[PATCH v2 06/10] wireless: iwlegacy: constify attribute_group structures.
[PATCH v2 07/10] wireless: iwlegacy: Constify attribute_group structures.
[PATCH v2 08/10] arcnet: com20020-pci: constify attribute_group structures.
[PATCH v2 09/10] net: bonding: constify attribute_group structures.
[PATCH v2 10/10] net: chelsio: cxgb3: constify attribute_group structures.

drivers/net/arcnet/com20020-pci.c | 2 +-
drivers/net/bonding/bond_sysfs.c | 2 +-
drivers/net/can/at91_can.c | 2 +-
drivers/net/can/janz-ican3.c | 2 +-
drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c | 8 ++++++--
drivers/net/usb/cdc_ncm.c | 2 +-
drivers/net/wireless/intel/ipw2x00/ipw2100.c | 2 +-
drivers/net/wireless/intel/ipw2x00/ipw2200.c | 2 +-
drivers/net/wireless/intel/iwlegacy/3945-mac.c | 2 +-
drivers/net/wireless/intel/iwlegacy/4965-mac.c | 2 +-
10 files changed, 15 insertions(+), 11 deletions(-)

--
1.9.1

2017-07-11 07:33:25

by Arvind Yadav

[permalink] [raw]

Subject: [PATCH v2 06/10] wireless: iwlegacy: constify attribute_group structures.

attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work
with const attribute_group. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <[email protected]>
---
Changes in v2:
Added cover later.

drivers/net/wireless/intel/iwlegacy/3945-mac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intel/iwlegacy/3945-mac.c b/drivers/net/wireless/intel/iwlegacy/3945-mac.c
index 38bf403..329f3a6 100644
--- a/drivers/net/wireless/intel/iwlegacy/3945-mac.c
+++ b/drivers/net/wireless/intel/iwlegacy/3945-mac.c
@@ -3464,7 +3464,7 @@ static DEVICE_ATTR(antenna, S_IWUSR | S_IRUGO, il3945_show_antenna,
NULL
};

-static struct attribute_group il3945_attribute_group = {
+static const struct attribute_group il3945_attribute_group = {
.name = NULL, /* put in device directory */
.attrs = il3945_sysfs_entries,
};
--
1.9.1

2017-07-11 07:34:50

by Arvind Yadav

[permalink] [raw]

Subject: [PATCH v2 07/10] wireless: iwlegacy: Constify attribute_group structures.

attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work
with const attribute_group. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <[email protected]>
---
Changes in v2:
Added cover later.

drivers/net/wireless/intel/iwlegacy/4965-mac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intel/iwlegacy/4965-mac.c b/drivers/net/wireless/intel/iwlegacy/4965-mac.c
index 5b51fba..de9b652 100644
--- a/drivers/net/wireless/intel/iwlegacy/4965-mac.c
+++ b/drivers/net/wireless/intel/iwlegacy/4965-mac.c
@@ -4654,7 +4654,7 @@ static DEVICE_ATTR(tx_power, S_IWUSR | S_IRUGO, il4965_show_tx_power,
NULL
};

-static struct attribute_group il_attribute_group = {
+static const struct attribute_group il_attribute_group = {
.name = NULL, /* put in device directory */
.attrs = il_sysfs_entries,
};
--
1.9.1

2017-07-25 12:55:59

by Kalle Valo

[permalink] [raw]

Subject: Re: [PATCH v2 00/10] Constify attribute_group structures

Arvind Yadav <[email protected]> writes:

> attribute_groups are not supposed to change at runtime. So mark the
> non-const structs as const.
>
> Arvind Yadav (10):
> [PATCH v2 01/10] net: cdc_ncm: constify attribute_group structures.
> [PATCH v2 02/10] net: can: at91_can: constify attribute_group structures.
> [PATCH v2 03/10] net: can: janz-ican3: constify attribute_group structures.
> [PATCH v2 04/10] wireless: ipw2200: constify attribute_group structures.
> [PATCH v2 05/10] wireless: ipw2100: constify attribute_group structures.
> [PATCH v2 06/10] wireless: iwlegacy: constify attribute_group structures.
> [PATCH v2 07/10] wireless: iwlegacy: Constify attribute_group structures.
> [PATCH v2 08/10] arcnet: com20020-pci: constify attribute_group structures.
> [PATCH v2 09/10] net: bonding: constify attribute_group structures.
> [PATCH v2 10/10] net: chelsio: cxgb3: constify attribute_group structures.

Via which tree were you planning to push these? Is it ok if I take the
wireless patches to my tree?

--
Kalle Valo

2017-07-26 06:36:03

by Arvind Yadav

[permalink] [raw]

Subject: Re: [PATCH v2 00/10] Constify attribute_group structures

Hi Kalle,

On Tuesday 25 July 2017 06:25 PM, Kalle Valo wrote:
> Arvind Yadav <[email protected]> writes:
>
>> attribute_groups are not supposed to change at runtime. So mark the
>> non-const structs as const.
>>
>> Arvind Yadav (10):
>> [PATCH v2 01/10] net: cdc_ncm: constify attribute_group structures.
>> [PATCH v2 02/10] net: can: at91_can: constify attribute_group structures.
>> [PATCH v2 03/10] net: can: janz-ican3: constify attribute_group structures.
>> [PATCH v2 04/10] wireless: ipw2200: constify attribute_group structures.
>> [PATCH v2 05/10] wireless: ipw2100: constify attribute_group structures.
>> [PATCH v2 06/10] wireless: iwlegacy: constify attribute_group structures.
>> [PATCH v2 07/10] wireless: iwlegacy: Constify attribute_group structures.
>> [PATCH v2 08/10] arcnet: com20020-pci: constify attribute_group structures.
>> [PATCH v2 09/10] net: bonding: constify attribute_group structures.
>> [PATCH v2 10/10] net: chelsio: cxgb3: constify attribute_group structures.
> Via which tree were you planning to push these? Is it ok if I take the
> wireless patches to my tree?
>
I have push these changes to linux-branch. you can take this to your branch.

~arvind

2017-07-26 06:36:54

by Arvind Yadav

[permalink] [raw]