2017-07-16 22:56:53

by Gabriel C

Subject: ath10k_htt_rx_amsdu_allowed() noise

Hello,

each time I disconnect my card from AP my dmesg gets flooded like this :

...
ath10k_pci 0000:03:00.0: no channel configured; ignoring frame(s)!
<until ratelimit kicks in>
ath10k_warn: 155 callbacks suppressed
<and so on>

Can ath10k_warn() be ath10k_dbg() there ? Maybe this ?


From d4138d936635ca7b69ed7f7b0cda4914f0f07917 Mon Sep 17 00:00:00 2001
From: Gabriel Craciunescu <[email protected]>
Date: Mon, 17 Jul 2017 00:45:29 +0200
Subject: [PATCH] ath10k_htt_rx_amsdu_allowed(): change ath10k_warn() to th10k_dbg()

Signed-off-by: Gabriel Craciunescu <[email protected]>
---
drivers/net/wireless/ath/ath10k/htt_rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
index 398dda978d6e..ad0306cd6ee1 100644
--- a/drivers/net/wireless/ath/ath10k/htt_rx.c
+++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
@@ -1514,7 +1514,7 @@ static bool ath10k_htt_rx_amsdu_allowed(struct ath10k *ar,
*/

if (!rx_status->freq) {
- ath10k_warn(ar, "no channel configured; ignoriframe(s)!\n");
+ ath10k_dbg(ar, ATH10K_DBG_HTT, "no channel configured, ignoring frame(s)!\n");
return false;
}

--
2.13.3

2017-07-18 07:14:53

by Ryan Hsu

Subject: Re: ath10k_htt_rx_amsdu_allowed() noise

On 07/16/2017 03:56 PM, Gabriel C wrote:

>
> Can ath10k_warn() be ath10k_dbg() there ? Maybe this ?
>

Looks good to me.

>
> From d4138d936635ca7b69ed7f7b0cda4914f0f07917 Mon Sep 17 00:00:00 2001
> From: Gabriel Craciunescu <[email protected]>
> Date: Mon, 17 Jul 2017 00:45:29 +0200
> Subject: [PATCH] ath10k_htt_rx_amsdu_allowed(): change ath10k_warn() to th10k_dbg()
>
> Signed-off-by: Gabriel Craciunescu <[email protected]>
> ---
> drivers/net/wireless/ath/ath10k/htt_rx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
> index 398dda978d6e..ad0306cd6ee1 100644
> --- a/drivers/net/wireless/ath/ath10k/htt_rx.c
> +++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
> @@ -1514,7 +1514,7 @@ static bool ath10k_htt_rx_amsdu_allowed(struct ath10k *ar,
> */
>
> if (!rx_status->freq) {
> - ath10k_warn(ar, "no channel configured; ignoriframe(s)!\n");
> + ath10k_dbg(ar, ATH10K_DBG_HTT, "no channel configured, ignoring frame(s)!\n");
> return false;
> }
>

Can you send this as patch for reviewing, please?

--
Ryan Hsu

2017-07-19 15:00:41

by Gabriel C

Subject: Re: ath10k_htt_rx_amsdu_allowed() noise

On 18.07.2017 09:14, Ryan Hsu wrote:
> On 07/16/2017 03:56 PM, Gabriel C wrote:
>
>>
>> Can ath10k_warn() be ath10k_dbg() there ? Maybe this ?
>>
>
> Looks good to me.
>
>>
>> From d4138d936635ca7b69ed7f7b0cda4914f0f07917 Mon Sep 17 00:00:00 2001
>> From: Gabriel Craciunescu <[email protected]>
>> Date: Mon, 17 Jul 2017 00:45:29 +0200
>> Subject: [PATCH] ath10k_htt_rx_amsdu_allowed(): change ath10k_warn() to th10k_dbg()
>>
>> Signed-off-by: Gabriel Craciunescu <[email protected]>
>> ---
>> drivers/net/wireless/ath/ath10k/htt_rx.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
>> index 398dda978d6e..ad0306cd6ee1 100644
>> --- a/drivers/net/wireless/ath/ath10k/htt_rx.c
>> +++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
>> @@ -1514,7 +1514,7 @@ static bool ath10k_htt_rx_amsdu_allowed(struct ath10k *ar,
>> */
>>
>> if (!rx_status->freq) {
>> - ath10k_warn(ar, "no channel configured; ignoriframe(s)!\n");
>> + ath10k_dbg(ar, ATH10K_DBG_HTT, "no channel configured, ignoring frame(s)!\n");
>> return false;
>> }
>>
>
> Can you send this as patch for reviewing, please?
>

Sure .. I'll try to send the patch to the list later on today..

Regards,

Gabriel C