2017-07-18 17:05:30

by Arvind Yadav

Subject: [PATCH] ALSA: hda: constify pci_device_id.

pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

File size before:
text data bss dec hex filename
2610 304 8 2922 b6a sound/hda/hdac_i915.o

File size After adding 'const':
text data bss dec hex filename
2674 240 8 2922 b6a sound/hda/hdac_i915.o

Signed-off-by: Arvind Yadav <[email protected]>
---
sound/hda/hdac_i915.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/hda/hdac_i915.c b/sound/hda/hdac_i915.c
index 0659bf3..038a180 100644
--- a/sound/hda/hdac_i915.c
+++ b/sound/hda/hdac_i915.c
@@ -336,7 +336,7 @@ EXPORT_SYMBOL_GPL(snd_hdac_i915_register_notifier);
/* check whether intel graphics is present */
static bool i915_gfx_present(void)
{
- static struct pci_device_id ids[] = {
+ static const struct pci_device_id ids[] = {
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_ANY_ID),
.class = PCI_BASE_CLASS_DISPLAY << 16,
.class_mask = 0xff << 16 },
--
2.7.4

2017-07-18 18:02:07

by Takashi Iwai

Subject: Re: [PATCH] ALSA: hda: constify pci_device_id.

On Tue, 18 Jul 2017 19:05:06 +0200,
Arvind Yadav wrote:
>
> pci_device_id are not supposed to change at runtime. All functions
> working with pci_device_id provided by <linux/pci.h> work with
> const pci_device_id. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 2610 304 8 2922 b6a sound/hda/hdac_i915.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 2674 240 8 2922 b6a sound/hda/hdac_i915.o
>
> Signed-off-by: Arvind Yadav <[email protected]>

Applied, thanks.


Takashi