2001-03-04 23:30:35

by Zach Brown

[permalink] [raw]
Subject: [CFT] maestro update vs 2.2.18

I finally spent some time fixing up the maestro driver. lots of
feature additions had backed up, and the source was rotting. Its still
gross, but at least its cleaned up a bit. "It works for me" on my
pentium with an ESS maestro2 engineering board, but laptops will be
another story entirely. I'd love it if people could apply this patch to
vanilla 2.2.18 and let me know how it goes.

The patch does a few things. Most interestingly for the user, it moves
away from the model of having multiple /dev/dsp? files and instead allows
/dev/dsp to be opened concurrently. It also adds some support for the
hardware volume buttons on laptops, but not all vendors wire this the same
way. As I don't have a maestro-bearing laptop, this is totally untested.

The code is butchered, so the diff is almost illegible. Perhaps I'll
learn and do things in stages next time, but I was on a roll :) One
of the more notable changes involves using the kernel's ac97_codec
code rather than its own. Hopefully this will result in better mixer
behaviour.

I'm particularly interested in hearing how suspend/resume functions,
whether or not the multi-open stuff works, and I'd like to get subvendor
IDs from people whose laptop's hardware volume buttons work. See the
Documentation/sound/Maestro text for instructions on enabling multi-open
(channels=2 or 4) and hardware volume support (hw_vol=1).

Its an awfully large diff, so it can be fetched from:

http://www.zabbo.net/maestro/patches/2.2.18-mega-1.diff.gz

if this works I'll officially submit it and make the same sorts of
changes to 2.4.

--
zach


2001-03-05 01:45:18

by Tom Sightler

[permalink] [raw]
Subject: Re: [CFT] maestro update vs 2.2.18

> Its an awfully large diff, so it can be fetched from:
>
> http://www.zabbo.net/maestro/patches/2.2.18-mega-1.diff.gz
>
> if this works I'll officially submit it and make the same sorts of
> changes to 2.4.

I'd love to test this on my Dell 5000e (Maestro 2E) but it's pretty
impractical for me to return to the 2.2.x kernels. I know you said you'll
wait before making the changes to 2.4, but I think you'll get more testers
if you turn it out sooner rather than later.

Later,
Tom