2003-07-02 22:01:09

by Davide Libenzi

Subject: [patch] Hardly triggered tests in bootmem.c ...

I was looking at the bootmem.c source and I found those hardly triggered
tests (unsigned long's).
(Andrew, sending the patch insted of the note)


- Davide




--- linux-2.5.73/mm/bootmem.c.orig 2003-07-02 14:55:47.000000000 -0700
+++ linux-2.5.73/mm/bootmem.c 2003-07-02 14:56:51.000000000 -0700
@@ -84,10 +84,6 @@

if (!size) BUG();

- if (sidx < 0)
- BUG();
- if (eidx < 0)
- BUG();
if (sidx >= eidx)
BUG();
if ((addr >> PAGE_SHIFT) >= bdata->node_low_pfn)

2003-07-03 14:32:05

by Michael Buesch

Subject: Re: [patch] Hardly triggered tests in bootmem.c ...

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thursday 03 July 2003 00:07, Davide Libenzi wrote:
> I was looking at the bootmem.c source and I found those hardly triggered
> tests (unsigned long's).
> (Andrew, sending the patch insted of the note)
>
>
> - Davide
>
>
>
>
> --- linux-2.5.73/mm/bootmem.c.orig 2003-07-02 14:55:47.000000000 -0700
> +++ linux-2.5.73/mm/bootmem.c 2003-07-02 14:56:51.000000000 -0700
> @@ -84,10 +84,6 @@
>
> if (!size) BUG();
>
> - if (sidx < 0)
> - BUG();
> - if (eidx < 0)
> - BUG();
> if (sidx >= eidx)
> BUG();
> if ((addr >> PAGE_SHIFT) >= bdata->node_low_pfn)

shouldn't we convert the remaining
if (x)
BUG();

to
BUG_ON(x)

?

- --
Regards Michael Buesch
http://www.8ung.at/tuxsoft
16:44:38 up 1:00, 1 user, load average: 1.00, 1.00, 0.95

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE/BEG6oxoigfggmSgRAuFAAJ4iJfEdI5J+SBrDQ9CZM3eEwDC6iwCcDyL7
ssuTGbtylaaqagOLLtYi3ds=
=4xv5
-----END PGP SIGNATURE-----