Subject: ramfs & a_ops->truncatepage()


I'm looking at this part of 2.4.2-ac8:

diff -u --new-file --recursive --exclude-from /usr/src/exclude linux-2.4.0/mm/filemap.c
linux.ac/mm/filemap.c
--- linux-2.4.0/mm/filemap.c Wed Jan 3 02:59:45 2001
+++ linux.ac/mm/filemap.c Thu Jan 11 17:26:55 2001
@@ -206,6 +206,9 @@
if (!page->buffers || block_flushpage(page, 0))
lru_cache_del(page);

+ if (page->mapping->a_ops->truncatepage)
+ page->mapping->a_ops->truncatepage(page);
+
/*
* We remove the page from the page cache _after_ we have
* destroyed all buffer-cache references to it. Otherwise some
----------

Does anyone know who proposed these changes as part of
ramfs enhancements? Basically, we have a very similar
operation in XFS, but would like the call to truncatepage
be _before_ the call to block_flushpage(). As far as ramfs
is concerned, such a change would be a no-op since ramfs doesn't
have page->buffers. Is this correct?

thanks,

ananth.

--------------------------------------------------------------------------
Rajagopal Ananthanarayanan ("ananth")
Member Technical Staff, SGI.
--------------------------------------------------------------------------