2018-01-13 12:42:27

by Karim Eshapa

Subject: bpf: Change structure passing and assignment

I noticed that most of functions here have structure arguements and return structure, all these structures passed and returned are delt in passing and assignment like memcpy a structure.In addition it takes size in stack while passing. so why not we use pointers to structure as argumentsor there is actual need to do such things and you intentionaly want to deal with copies of strucuteres.
ex:
struct tnum tnum_add(struct tnum a, struct tnum b)
{

}

Thanks,
Karim

2018-01-13 16:24:48

by Alexei Starovoitov

Subject: Re: bpf: Change structure passing and assignment

On Sat, Jan 13, 2018 at 02:42:19PM +0200, Karim Eshapa wrote:
> I noticed that most of functions here have structure arguements and return structure, all these structures passed and returned are delt in passing and assignment like memcpy a structure.In addition it takes size in stack while passing. so why not we use pointers to structure as argumentsor there is actual need to do such things and you intentionaly want to deal with copies of strucuteres.
> ex:
> struct tnum tnum_add(struct tnum a, struct tnum b)

and how an alternative for the above would look like with pointers ?