2018-01-23 13:38:50

by Luis de Bethencourt

[permalink] [raw]
Subject: [PATCH] MIPS: Fix trailing semicolon

The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.

Signed-off-by: Luis de Bethencourt <[email protected]>
---

Hi,

After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].

Best regards
Luis


[0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
[1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html

arch/mips/include/asm/checksum.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/include/asm/checksum.h b/arch/mips/include/asm/checksum.h
index 77cad232a1c6..e8161e4dfde7 100644
--- a/arch/mips/include/asm/checksum.h
+++ b/arch/mips/include/asm/checksum.h
@@ -110,7 +110,7 @@ __wsum csum_partial_copy_nocheck(const void *src, void *dst,
*/
static inline __sum16 csum_fold(__wsum csum)
{
- u32 sum = (__force u32)csum;;
+ u32 sum = (__force u32)csum;

sum += (sum << 16);
csum = (sum < csum);
--
2.15.1



2018-02-01 16:09:00

by James Hogan

[permalink] [raw]
Subject: Re: [PATCH] MIPS: Fix trailing semicolon

On Tue, Jan 23, 2018 at 01:38:03PM +0000, Luis de Bethencourt wrote:
> The trailing semicolon is an empty statement that does no operation.
> Removing it since it doesn't do anything.
>
> Signed-off-by: Luis de Bethencourt <[email protected]>

Applied to my 4.16 branch,

Thanks
James

> ---
>
> Hi,
>
> After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
> suggested I fix it treewide [0].
>
> Best regards
> Luis
>
>
> [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
> [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html
>
> arch/mips/include/asm/checksum.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/include/asm/checksum.h b/arch/mips/include/asm/checksum.h
> index 77cad232a1c6..e8161e4dfde7 100644
> --- a/arch/mips/include/asm/checksum.h
> +++ b/arch/mips/include/asm/checksum.h
> @@ -110,7 +110,7 @@ __wsum csum_partial_copy_nocheck(const void *src, void *dst,
> */
> static inline __sum16 csum_fold(__wsum csum)
> {
> - u32 sum = (__force u32)csum;;
> + u32 sum = (__force u32)csum;
>
> sum += (sum << 16);
> csum = (sum < csum);
> --
> 2.15.1
>


Attachments:
(No filename) (1.24 kB)
signature.asc (849.00 B)
Digital signature
Download all attachments