2018-01-25 10:27:17

by Rohit Visavalia

[permalink] [raw]
Subject: [PATCH] qed: code indent should use tabs where possible

Issue found by checkpatch.

Signed-off-by: Rohit Visavalia <[email protected]>
---
drivers/net/ethernet/qlogic/qed/qed_rdma.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/qed/qed_rdma.c b/drivers/net/ethernet/qlogic/qed/qed_rdma.c
index b7abb8205d3a..ae399c48d4a3 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_rdma.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_rdma.c
@@ -360,13 +360,13 @@ static void qed_rdma_resc_free(struct qed_hwfn *p_hwfn)

static void qed_rdma_free_tid(void *rdma_cxt, u32 itid)
{
- struct qed_hwfn *p_hwfn = (struct qed_hwfn *)rdma_cxt;
+ struct qed_hwfn *p_hwfn = (struct qed_hwfn *)rdma_cxt;

- DP_VERBOSE(p_hwfn, QED_MSG_RDMA, "itid = %08x\n", itid);
+ DP_VERBOSE(p_hwfn, QED_MSG_RDMA, "itid = %08x\n", itid);

- spin_lock_bh(&p_hwfn->p_rdma_info->lock);
- qed_bmap_release_id(p_hwfn, &p_hwfn->p_rdma_info->tid_map, itid);
- spin_unlock_bh(&p_hwfn->p_rdma_info->lock);
+ spin_lock_bh(&p_hwfn->p_rdma_info->lock);
+ qed_bmap_release_id(p_hwfn, &p_hwfn->p_rdma_info->tid_map, itid);
+ spin_unlock_bh(&p_hwfn->p_rdma_info->lock);
}

static void qed_rdma_free_reserved_lkey(struct qed_hwfn *p_hwfn)
--
2.16.1



2018-01-25 10:32:43

by Kalderon, Michal

[permalink] [raw]
Subject: RE: [PATCH] qed: code indent should use tabs where possible

> From: Rohit Visavalia [mailto:[email protected]]
> Sent: Thursday, January 25, 2018 12:26 PM
> To: Elior, Ariel <[email protected]>; Dept-Eng Everest Linux L2 <Dept-
> [email protected]>
> Cc: [email protected]; [email protected]; Rohit Visavalia
> <[email protected]>
> Subject: [PATCH] qed: code indent should use tabs where possible
>
> Issue found by checkpatch.
>
> Signed-off-by: Rohit Visavalia <[email protected]>
> ---
> drivers/net/ethernet/qlogic/qed/qed_rdma.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_rdma.c
> b/drivers/net/ethernet/qlogic/qed/qed_rdma.c
> index b7abb8205d3a..ae399c48d4a3 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_rdma.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_rdma.c
> @@ -360,13 +360,13 @@ static void qed_rdma_resc_free(struct qed_hwfn
> *p_hwfn)
>
> static void qed_rdma_free_tid(void *rdma_cxt, u32 itid) {
> - struct qed_hwfn *p_hwfn = (struct qed_hwfn *)rdma_cxt;
> + struct qed_hwfn *p_hwfn = (struct qed_hwfn *)rdma_cxt;
>
> - DP_VERBOSE(p_hwfn, QED_MSG_RDMA, "itid = %08x\n", itid);
> + DP_VERBOSE(p_hwfn, QED_MSG_RDMA, "itid = %08x\n", itid);
>
> - spin_lock_bh(&p_hwfn->p_rdma_info->lock);
> - qed_bmap_release_id(p_hwfn, &p_hwfn->p_rdma_info->tid_map,
> itid);
> - spin_unlock_bh(&p_hwfn->p_rdma_info->lock);
> + spin_lock_bh(&p_hwfn->p_rdma_info->lock);
> + qed_bmap_release_id(p_hwfn, &p_hwfn->p_rdma_info->tid_map,
> itid);
> + spin_unlock_bh(&p_hwfn->p_rdma_info->lock);
> }
>
> static void qed_rdma_free_reserved_lkey(struct qed_hwfn *p_hwfn)
> --
> 2.16.1

Thanks and apologies,

Acked-by: Michal Kalderon <[email protected]>

2018-01-25 21:38:22

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] qed: code indent should use tabs where possible

From: Rohit Visavalia <[email protected]>
Date: Thu, 25 Jan 2018 15:56:14 +0530

> Issue found by checkpatch.
>
> Signed-off-by: Rohit Visavalia <[email protected]>

Applied to net-next.