2003-07-27 11:31:24

by Sean Estabrooks

[permalink] [raw]
Subject: [PATCH] Block layer bug handling partial bvec

Previously I submitted a patch for "blk: request botched" on floppy
write. While the patch did make the floppy work, Jens mentioned
that an underlying error still existed. This spurred me on to look a
little deeper and finally i found the root cause.

There is a bug in "ll_rw_blk.c" handling partial bvec submissions.
For whatever reason the floppy driver was triggering it more than
other users. Note that with the attached patch, my previous
floppy_ patch is no longer needed.

Cheers,
Sean


Attachments:
blk_partial_bvec.patch (490.00 B)

2003-07-27 12:48:20

by Jens Axboe

[permalink] [raw]
Subject: Re: [PATCH] Block layer bug handling partial bvec

On Sun, Jul 27 2003, Sean Estabrooks wrote:
> Previously I submitted a patch for "blk: request botched" on floppy
> write. While the patch did make the floppy work, Jens mentioned
> that an underlying error still existed. This spurred me on to look a
> little deeper and finally i found the root cause.
>
> There is a bug in "ll_rw_blk.c" handling partial bvec submissions.
> For whatever reason the floppy driver was triggering it more than
> other users. Note that with the attached patch, my previous
> floppy_ patch is no longer needed.

Good catch! Applied.

--
Jens Axboe