2018-03-13 10:50:59

by Du, Changbin

Subject: [PATCH] perf trace: remove redundant ')'

From: Changbin Du <[email protected]>

There is a redundant ')' at the tail of each event. So remove it.
$ sudo perf trace --no-syscalls -e 'kmem:*' -a
899.342 kmem:kfree:(vfs_writev+0xb9) call_site=ffffffff9c453979 ptr=(nil))
899.344 kmem:kfree:(___sys_recvmsg+0x188) call_site=ffffffff9c9b8b88 ptr=(nil))

Signed-off-by: Changbin Du <[email protected]>
---
tools/perf/builtin-trace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index e7f1b18..7273f5f 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -1959,7 +1959,7 @@ static int trace__event_handler(struct trace *trace, struct perf_evsel *evsel,
trace->output);
}

- fprintf(trace->output, ")\n");
+ fprintf(trace->output, "\n");

if (callchain_ret > 0)
trace__fprintf_callchain(trace, sample);
--
2.7.4

2018-03-16 08:01:56

by Du, Changbin

Subject: Re: [PATCH] perf trace: remove redundant ')'

Hi Arnaldo, How about this simple one? Thanks.

On Tue, Mar 13, 2018 at 06:40:01PM +0800, [email protected] wrote:
> From: Changbin Du <[email protected]>
>
> There is a redundant ')' at the tail of each event. So remove it.
> $ sudo perf trace --no-syscalls -e 'kmem:*' -a
> 899.342 kmem:kfree:(vfs_writev+0xb9) call_site=ffffffff9c453979 ptr=(nil))
> 899.344 kmem:kfree:(___sys_recvmsg+0x188) call_site=ffffffff9c9b8b88 ptr=(nil))
>
> Signed-off-by: Changbin Du <[email protected]>
> ---
> tools/perf/builtin-trace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> index e7f1b18..7273f5f 100644
> --- a/tools/perf/builtin-trace.c
> +++ b/tools/perf/builtin-trace.c
> @@ -1959,7 +1959,7 @@ static int trace__event_handler(struct trace *trace, struct perf_evsel *evsel,
> trace->output);
> }
>
> - fprintf(trace->output, ")\n");
> + fprintf(trace->output, "\n");
>
> if (callchain_ret > 0)
> trace__fprintf_callchain(trace, sample);
> --
> 2.7.4
>

--
Thanks,
Changbin Du

2018-03-16 12:52:13

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH] perf trace: remove redundant ')'

Em Fri, Mar 16, 2018 at 03:51:09PM +0800, Du, Changbin escreveu:
> Hi Arnaldo, How about this simple one? Thanks.
>
> On Tue, Mar 13, 2018 at 06:40:01PM +0800, [email protected] wrote:
> > From: Changbin Du <[email protected]>
> >
> > There is a redundant ')' at the tail of each event. So remove it.
> > $ sudo perf trace --no-syscalls -e 'kmem:*' -a
> > 899.342 kmem:kfree:(vfs_writev+0xb9) call_site=ffffffff9c453979 ptr=(nil))
> > 899.344 kmem:kfree:(___sys_recvmsg+0x188) call_site=ffffffff9c9b8b88 ptr=(nil))
> >
> > Signed-off-by: Changbin Du <[email protected]>
> > ---
> > tools/perf/builtin-trace.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> > index e7f1b18..7273f5f 100644
> > --- a/tools/perf/builtin-trace.c
> > +++ b/tools/perf/builtin-trace.c
> > @@ -1959,7 +1959,7 @@ static int trace__event_handler(struct trace *trace, struct perf_evsel *evsel,
> > trace->output);
> > }
> >
> > - fprintf(trace->output, ")\n");
> > + fprintf(trace->output, "\n");

It looks simple on the surface, but I couldn't quickly recall why this
')' was put there in the first place... So I left for later to do a 'git
blame' on this file, etc.

- Arnaldo

> > if (callchain_ret > 0)
> > trace__fprintf_callchain(trace, sample);
> > --
> > 2.7.4
> >
>
> --
> Thanks,
> Changbin Du

2018-03-28 08:02:25

by Du, Changbin

Subject: Re: [PATCH] perf trace: remove redundant ')'

Hi Arnaldo,
Just a kind reminder. Hope you didn't forget this.

On Fri, Mar 16, 2018 at 09:50:45AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, Mar 16, 2018 at 03:51:09PM +0800, Du, Changbin escreveu:
> > Hi Arnaldo, How about this simple one? Thanks.
> >
> > On Tue, Mar 13, 2018 at 06:40:01PM +0800, [email protected] wrote:
> > > From: Changbin Du <[email protected]>
> > >
> > > There is a redundant ')' at the tail of each event. So remove it.
> > > $ sudo perf trace --no-syscalls -e 'kmem:*' -a
> > > 899.342 kmem:kfree:(vfs_writev+0xb9) call_site=ffffffff9c453979 ptr=(nil))
> > > 899.344 kmem:kfree:(___sys_recvmsg+0x188) call_site=ffffffff9c9b8b88 ptr=(nil))
> > >
> > > Signed-off-by: Changbin Du <[email protected]>
> > > ---
> > > tools/perf/builtin-trace.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> > > index e7f1b18..7273f5f 100644
> > > --- a/tools/perf/builtin-trace.c
> > > +++ b/tools/perf/builtin-trace.c
> > > @@ -1959,7 +1959,7 @@ static int trace__event_handler(struct trace *trace, struct perf_evsel *evsel,
> > > trace->output);
> > > }
> > >
> > > - fprintf(trace->output, ")\n");
> > > + fprintf(trace->output, "\n");
>
> It looks simple on the surface, but I couldn't quickly recall why this
> ')' was put there in the first place... So I left for later to do a 'git
> blame' on this file, etc.
>
> - Arnaldo
>
> > > if (callchain_ret > 0)
> > > trace__fprintf_callchain(trace, sample);
> > > --
> > > 2.7.4
> > >
> >
> > --
> > Thanks,
> > Changbin Du

--
Thanks,
Changbin Du

2018-04-03 19:20:28

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH] perf trace: remove redundant ')'

Em Wed, Mar 28, 2018 at 03:26:31PM +0800, Du, Changbin escreveu:
> Hi Arnaldo,
> Just a kind reminder. Hope you didn't forget this.

Ok, applied.

- Arnaldo

> On Fri, Mar 16, 2018 at 09:50:45AM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Fri, Mar 16, 2018 at 03:51:09PM +0800, Du, Changbin escreveu:
> > > Hi Arnaldo, How about this simple one? Thanks.
> > >
> > > On Tue, Mar 13, 2018 at 06:40:01PM +0800, [email protected] wrote:
> > > > From: Changbin Du <[email protected]>
> > > >
> > > > There is a redundant ')' at the tail of each event. So remove it.
> > > > $ sudo perf trace --no-syscalls -e 'kmem:*' -a
> > > > 899.342 kmem:kfree:(vfs_writev+0xb9) call_site=ffffffff9c453979 ptr=(nil))
> > > > 899.344 kmem:kfree:(___sys_recvmsg+0x188) call_site=ffffffff9c9b8b88 ptr=(nil))
> > > >
> > > > Signed-off-by: Changbin Du <[email protected]>
> > > > ---
> > > > tools/perf/builtin-trace.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> > > > index e7f1b18..7273f5f 100644
> > > > --- a/tools/perf/builtin-trace.c
> > > > +++ b/tools/perf/builtin-trace.c
> > > > @@ -1959,7 +1959,7 @@ static int trace__event_handler(struct trace *trace, struct perf_evsel *evsel,
> > > > trace->output);
> > > > }
> > > >
> > > > - fprintf(trace->output, ")\n");
> > > > + fprintf(trace->output, "\n");
> >
> > It looks simple on the surface, but I couldn't quickly recall why this
> > ')' was put there in the first place... So I left for later to do a 'git
> > blame' on this file, etc.
> >
> > - Arnaldo
> >
> > > > if (callchain_ret > 0)
> > > > trace__fprintf_callchain(trace, sample);
> > > > --
> > > > 2.7.4
> > > >
> > >
> > > --
> > > Thanks,
> > > Changbin Du
>
> --
> Thanks,
> Changbin Du

2018-04-04 02:43:19

by Du, Changbin

Subject: Re: [PATCH] perf trace: remove redundant ')'

On Tue, Apr 03, 2018 at 04:19:07PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Mar 28, 2018 at 03:26:31PM +0800, Du, Changbin escreveu:
> > Hi Arnaldo,
> > Just a kind reminder. Hope you didn't forget this.
>
> Ok, applied.
>
> - Arnaldo
>
Got it, thanks!

2018-04-04 05:38:25

by tip-bot for Vasyl Gomonovych

Subject: [tip:perf/urgent] perf trace: Remove redundant ')'

Commit-ID: 51125a29a395048fdb3429b8c4ca0ada57097744
Gitweb: https://git.kernel.org/tip/51125a29a395048fdb3429b8c4ca0ada57097744
Author: Changbin Du <[email protected]>
AuthorDate: Tue, 13 Mar 2018 18:40:01 +0800
Committer: Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Tue, 3 Apr 2018 16:16:41 -0300

perf trace: Remove redundant ')'

There is a redundant ')' at the tail of each event. So remove it.

$ sudo perf trace --no-syscalls -e 'kmem:*' -a
899.342 kmem:kfree:(vfs_writev+0xb9) call_site=ffffffff9c453979 ptr=(nil))
899.344 kmem:kfree:(___sys_recvmsg+0x188) call_site=ffffffff9c9b8b88 ptr=(nil))

Signed-off-by: Changbin Du <[email protected]>
Tested-by: Arnaldo Carvalho de Melo <[email protected]>
Cc: Jiri Olsa <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
tools/perf/builtin-trace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index 4e03f0f68241..3ad17ee89403 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -1962,7 +1962,7 @@ static int trace__event_handler(struct trace *trace, struct perf_evsel *evsel,
trace->output);
}

- fprintf(trace->output, ")\n");
+ fprintf(trace->output, "\n");

if (callchain_ret > 0)
trace__fprintf_callchain(trace, sample);