The generated files udpgso* shouldn't be part of TEST_PROGS, they are
used by udpgso.sh and udpgsp_bench.sh. They should be added to the
TEST_GEN_FILES to get installed without being added to the main
run_kselftest.sh script.
Fixes: 3a687bef148d ("selftests: udp gso benchmark")
Signed-off-by: Anders Roxell <[email protected]>
---
tools/testing/selftests/net/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
index 44895de1a0c4..f0363387ef2f 100644
--- a/tools/testing/selftests/net/Makefile
+++ b/tools/testing/selftests/net/Makefile
@@ -11,9 +11,9 @@ TEST_GEN_PROGS_EXTENDED := in_netns.sh
TEST_GEN_FILES = socket
TEST_GEN_FILES += psock_fanout psock_tpacket msg_zerocopy
TEST_GEN_FILES += tcp_mmap tcp_inq
+TEST_GEN_FILES += udpgso udpgso_bench_tx udpgso_bench_rx
TEST_GEN_PROGS = reuseport_bpf reuseport_bpf_cpu reuseport_bpf_numa
TEST_GEN_PROGS += reuseport_dualstack reuseaddr_conflict
-TEST_GEN_PROGS += udpgso udpgso_bench_tx udpgso_bench_rx
include ../lib.mk
--
2.11.0
From: Anders Roxell <[email protected]>
Date: Fri, 4 May 2018 11:17:25 +0200
> The generated files udpgso* shouldn't be part of TEST_PROGS, they are
> used by udpgso.sh and udpgsp_bench.sh. They should be added to the
> TEST_GEN_FILES to get installed without being added to the main
> run_kselftest.sh script.
>
> Fixes: 3a687bef148d ("selftests: udp gso benchmark")
> Signed-off-by: Anders Roxell <[email protected]>
Applied, thanks.
FYI, we noticed the following commit (built with gcc-7):
commit: bfbdcbad0a4f4373056d4bdb015b3441a06670de ("selftests: net: add udpgso* to TEST_GEN_FILES")
url: https://github.com/0day-ci/linux/commits/Anders-Roxell/selftests-net-add-udpgso-to-TEST_GEN_FILES/20180504-223330
in testcase: kernel_selftests
with following parameters:
group: kselftests-02
test-description: The kernel contains a set of "self tests" under the tools/testing/selftests/ directory. These are intended to be small unit tests to exercise individual code paths in the kernel.
test-url: https://www.kernel.org/doc/Documentation/kselftest.txt
on test machine: 88 threads Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz with 64G memory
caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace):
selftests: udpgso_bench.sh
========================================
./udpgso_bench.sh: 67: ./udpgso_bench.sh: [[: not found
./udpgso_bench.sh: 69: ./udpgso_bench.sh: [[: not found
./udpgso_bench.sh: 25: local: -r: bad variable name
./udpgso_bench.sh: 7: local: -r: bad variable name
not ok 1..16 selftests: udpgso_bench.sh [FAIL]
To reproduce:
git clone https://github.com/intel/lkp-tests.git
cd lkp-tests
bin/lkp install job.yaml # job file is attached in this email
bin/lkp run job.yaml
Thanks,
Xiaolong